Give me the [mute] or [save] command, that's only what I've asked and still does .
Anyway, what I explain don't cover only the need to preserve precedent code : it is much more a general issue : use the good command at the good place : excessive in-line just set the mod more difficult to install and are the main source of errors while installing, excessive replace occurs to a higher risk of not being able to install a mod (as installing other templates does), excessive add would occurs in duplicate code at many spots, etc.
01: MODing Philosophy
Re: 01: MODing Philosophy
So...?
What is the solution?
Keep in mind our goal which is to find the best and safer way to let EM install successfully the maximum of MODs.
So in this context, full lines FIND for REPLACE WITH will drastically decrease EM chances to succeed, and WILL create (even manually and you knows it) issues for users as they will not be able to find these full lines to replaces them (you can't separate the 2 issues: you need a full line FIND before a full line REPLACE WITH).
On the other hand, IN-LINE commands are a "bit" more risky if you don't use EM. But is it really a sufficient reason?
Manual installation compatibility is preserved with the current official phpBB MOD template, this is enough no?
In fact, my real opinion is that EM will be very powerful and safe enough, so the majority of MOD installations in the future will be proceed by EM. So the "little" difficulty occurred by the necessary use of IN-LINE commands for manual installation is a minor problem IMO.
And in case EM has trouble to install a MOD, don't forget that you may uninstall it safely, immediately after having install it and done some tests (before unlocking the board for users).
Then, I really think that manual MOD installation will decrease quickly as soon as an EM final release will be available.
Just my 2c
What is the solution?
Keep in mind our goal which is to find the best and safer way to let EM install successfully the maximum of MODs.
So in this context, full lines FIND for REPLACE WITH will drastically decrease EM chances to succeed, and WILL create (even manually and you knows it) issues for users as they will not be able to find these full lines to replaces them (you can't separate the 2 issues: you need a full line FIND before a full line REPLACE WITH).
On the other hand, IN-LINE commands are a "bit" more risky if you don't use EM. But is it really a sufficient reason?
Manual installation compatibility is preserved with the current official phpBB MOD template, this is enough no?
In fact, my real opinion is that EM will be very powerful and safe enough, so the majority of MOD installations in the future will be proceed by EM. So the "little" difficulty occurred by the necessary use of IN-LINE commands for manual installation is a minor problem IMO.
And in case EM has trouble to install a MOD, don't forget that you may uninstall it safely, immediately after having install it and done some tests (before unlocking the board for users).
Then, I really think that manual MOD installation will decrease quickly as soon as an EM final release will be available.
Just my 2c
Eternal newbie
Re: 01: MODing Philosophy
No : as an author, my goals are to provide the best way to install a mod, whatever the tool is used.-=ET=- wrote:(../..)Keep in mind our goal which is to find the best and safer way to let EM install successfully the maximum of MODs.(../..)
Re: 01: MODing Philosophy
Ptirhiik
Even more it will be harder for a newbie to find where is the problem and proceed the in line add without precise instructions. I've already had many times this problem and that it's harder than an IN-LINE instruction.
Nothing is better for manual installation, that's wrong
There is no solution in what you said. It's only a statement.-=ET=- wrote:...full lines FIND for REPLACE WITH ... WILL create (even manually and you knows it) issues for users as they will not be able to find these full lines to replaces them (you can't separate the 2 issues: you need a full line FIND before a full line REPLACE WITH).
Even more it will be harder for a newbie to find where is the problem and proceed the in line add without precise instructions. I've already had many times this problem and that it's harder than an IN-LINE instruction.
Nothing is better for manual installation, that's wrong
Last edited by -=ET=- on Fri Sep 05, 2003 9:25 pm, edited 1 time in total.
Eternal newbie
- GPHemsley
- Registered User
- Posts: 1617
- Joined: Fri Apr 18, 2003 4:01 am
- Location: Long Beach, NY
- Contact:
Re: 01: MODing Philosophy
And the best method is using IN-LINE, is it not?Ptirhiik wrote:No : as an author, my goals are to provide the best way to install a mod, whatever the tool is used.
Gordon P. Hemsley
The GP Factory
EasyMOD Support Rant
My MODs: Topic Type MOD | View Topic Title While Posting MOD
The GP Factory
EasyMOD Support Rant
My MODs: Topic Type MOD | View Topic Title While Posting MOD
Re: 01: MODing Philosophy
Not in any case : that's my point : no command is better than another : it is only the way you use it that makes the difference : use the right at the right place is the key .
- GPHemsley
- Registered User
- Posts: 1617
- Joined: Fri Apr 18, 2003 4:01 am
- Location: Long Beach, NY
- Contact:
Re: 01: MODing Philosophy
Well, yes, that's true. Replace is not necessarily \"evil\", but it certainly should only be used as a last resort, as IN-LINE commands would be better in most cases.
Gordon P. Hemsley
The GP Factory
EasyMOD Support Rant
My MODs: Topic Type MOD | View Topic Title While Posting MOD
The GP Factory
EasyMOD Support Rant
My MODs: Topic Type MOD | View Topic Title While Posting MOD
-
- Registered User
- Posts: 4
- Joined: Sun Dec 19, 2004 5:17 pm
Re: 01: MODing Philosophy
Here's an idea. When a line is In-Line Modified, The original should be commented directly before. Then, when EasyMOD does a find, and sees these lines (commented and modified), it can better figure out what to do, like ask for user input on the best way to change the line.
EDIT: example
Original Line
After First MOD
New MOD looks for the original line but finds that it has been commented, and a modified line is just below
Tells user:
So the user could enter how to do this line manually. Or, if possible, EASYMOD could figure out that only one small change has been made and add the code accordingly.
EDIT: example
Original Line
Code: Select all
if ( $mode == 'editpost' || $mode == 'delete' || $mode == 'poll_delete' )
Code: Select all
//if ( $mode == 'editpost' || $mode == 'delete' || $mode == 'poll_delete' )
if ( $modes == 'editpost' || $modes == 'delete' || $modes == 'poll_delete' )
Tells user:
Code: Select all
Line
"if ( $mode == 'editpost' || $mode == 'delete' || $mode == 'poll_delete' )"
Has been Modified by another MOD to
"if ( $modes == 'editpost' || $modes == 'delete' || $modes == 'poll_delete' )"
Command was
... IN-LINE FIND - || $mode == 'poll_delete'
... In-LINE AFTER ADD - || $mode == 'bar'
Re: 01: MODing Philosophy
I would say this is a good one! The comment could include something like "EM oryginall" and do not always leave all the versions just the first one. Shouldn't be very complicated.
How To Ask Questions The Smart Way.
ReadMe ver. 0.0.4 for EasyMOD ver. 0.3.0 (on-line at sourceforge)
Recent problems that are not answered in the ReadMe.
My page: DOM, Javascript, SQL - tips&scripts (mostly in Polish, sorry )
ReadMe ver. 0.0.4 for EasyMOD ver. 0.3.0 (on-line at sourceforge)
Recent problems that are not answered in the ReadMe.
My page: DOM, Javascript, SQL - tips&scripts (mostly in Polish, sorry )