I fully agree with markus_petrux. This check is useless, and more, can be dangerous
Indeed, it exists 4 main phpBB upgrade methods, and this check is dangerous in any case!!!
You can upgrade phpBB by:
- an upgrade MOD (generally AcydBurn's one)
- replacing all the files by the new ones
- replacing only the changed files
- an upgrade patch
- if you upgrade phpBB by an upgrade MOD:
There is 2 possibilities: or there is no pb, no conflict, you can apply the upgrade MOD and of course all your MODs stay as is, fully installed; or trying to install the upgrade MOD you immediately detect some issues, you'll have to solve them, and once done, here again your MODs will stay fully installed (because in fact, solving the issues you'll have adapted the MODs to stay installed and become compliant).
=> So in this case the check is useless, and it's dangerous to suggest re-installing anything!
- if you upgrade by replacing all the phpBB files by the new ones:
Then this case is the best one for the interest of this check. But even here, EM suggests you to re-install in 3 clicks the whole MODs, including the DB modifications! 8O
=> So, even in this case there is a big issue as processing again SQL queries on an already upgraded DB can be dangerous!
- now if you replace only the changed files:
Here again this check is dangerous as EM will suggest you to fully re-install the MOD on some new files (OK), but also on some already MODed files (unchanged between the 2 phpBB version), and a DB already modified!
- and at last, if you want to use an upgrade patch:
This time, same as for an upgrade MOD, this check is useless (as all the MODs will stay fully installed) and dangerous because on the other hand you must NOT re-install anything!
So IMO, in any case this check is dangerous, as in any case it gives the possibility to re-install very easily the whole MODs in few clicks where in no case it's what must be done
And as EM doesn't have a clue of which upgrade method has been used, or we remove the check and say EM is not able to manage that, or we add a mandatory process:
- EM should be able to detect a new phpBB version
- them if the admin try to display an EM page, EM should ask which upgrade method has been used
- and if the answer is...
-> an upgrade MOD or an upgrade patch, EM should consider that the MODs are still fully installed
-> by replacing all the phpBB files by new ones, EM should suggests to re-install all the MODs except the SQL queries! (SQL queries should not be possible)
-> by replacing the changed files only by new ones, and EM... will be in the mess! lol
So it should IMO suggests to MOD again manually the new files (as EM doesn't know these files) and keep the MODs as is, so officially installed