Inline, Find -> After, Add doesn't do it quite right

Wondering why that MOD you have won't install correctly? Let's take a look
Forum rules
DO NOT give out any FTP passwords to anyone! There is no reason to do so! If you need help badly enough, create a temporary FTP account that is restricted to only the files that you need help with and give the information for that. Giving out FTP information can be very dangerous!
Locked
BassFace
Registered User
Posts: 5
Joined: Sun Mar 04, 2007 9:57 pm
Location: Aurora, CO
Contact:

Inline, Find -> After, Add doesn't do it quite right

Post by BassFace »

Hi all,
I am in the process of trying to make my mod easyMod 'friendly'. So I installed EasyMod on my test server and installed my MOD with it. After fixing a bunch of FIND statements that caused CRITICAL ERRORS, the MOD made it through the install!
However, it made a few mistakes, which I would like to figure out how to fix so easyMod can successfully install my MOD.

Error 1:

Code: Select all

#
#-----[ FIND ]------------------------------------------
#
validate_optional_fields($icq,
#
#-----[ IN-LINE FIND ]----------------------------------
#
 , $signature
#
#-----[ AFTER, ADD ]----------------------------------
#
, $map_center, $phoocomm
Got a CRITICAL ERROR with the whole 'validate_optional_fields()' line in the install file, so I chopped it to what's above. However, the resulting line after mod should be like this:

Code: Select all

validate_optional_fields($icq, $aim, $msn, $yim, $website, $location, $occupation, $interests, $signature, $map_center, $phoocomm);
but easyMod makes it like this:

Code: Select all

validate_optional_fields($icq, $aim, $msn, $yim, $website, $location, $occupation, $interests, $signature); 
,$map_center, $phoocomm
Error 2:
CSS div ID - I have to put a <style> block into some of the .tpl files and specify a <div> id name, like so:

Code: Select all

<style>
#phoogleMap 
  {
	position: relative;
	height: {MAP_HEIGHT}{HEIGHT_MEASURE};
	width: {MAP_WIDTH}{WIDTH_MEASURE};
	vertical-align: middle;
  }
</style>
EasyMOD only writes

Code: Select all

<style>
I assume its the '#' character that the install file uses as it's comment char.
Any thoughts on how I can get around these?
User avatar
Poomerio
Registered User
Posts: 552
Joined: Tue Jan 02, 2007 7:09 pm
Location: 4(x - 20y) = 20

Re: Inline, Find -> After, Add doesn't do it quite right

Post by Poomerio »

Provide me with a link to download the MOD and I will have a look for you :D
It looks very odd.. But if it's an IN LINE AFTER, ADD command, it will only add one line.

- Poomie
BassFace
Registered User
Posts: 5
Joined: Sun Mar 04, 2007 9:57 pm
Location: Aurora, CO
Contact:

Re: Inline, Find -> After, Add doesn't do it quite right

Post by BassFace »

Thanks very much. 8)
Here's the MOD as I submitted it to the MODDB (still in queue). http://bassface3d.com/uploads/phoogle_map_1.0.1.zip

And the install text after I made some corrections - this made it through the EasyMOD install, but with the errors I mentioned above. There may be more, but those are what I found on first glance. http://bassface3d.com/uploads/phoogle_m ... nstall.zip
User avatar
bonelifer
Community Team
Community Team
Posts: 114
Joined: Mon Jan 31, 2005 10:41 am

Re: Inline, Find -> After, Add doesn't do it quite right

Post by bonelifer »

That should look like this:

Code: Select all

#
#-----[ FIND ]------------------------------------------
#
validate_optional_fields($icq,
#
#-----[ IN-LINE FIND ]----------------------------------
#
, $signature
#
#-----[ IN-LINE AFTER, ADD ]----------------------------------
#
, $map_center, $phoocomm
Notice you have to have IN-LINE as part of the AFTER, ADD when used with an IN-LINE FIND. It's the same with all other command ACTIONS that use IN-LINE FIND.
User avatar
Poomerio
Registered User
Posts: 552
Joined: Tue Jan 02, 2007 7:09 pm
Location: 4(x - 20y) = 20

Re: Inline, Find -> After, Add doesn't do it quite right

Post by Poomerio »

Spot on.

OPEN
Install file

FIND

Code: Select all

#
#-----[ FIND ]------------------------------------------
#
validate_optional_fields($icq,
#
#-----[ IN-LINE FIND ]----------------------------------
#
, $signature
#
#-----[ AFTER, ADD ]----------------------------------
#
, $map_center, $phoocomm
REPLACE WITH

Code: Select all

#
#-----[ FIND ]------------------------------------------
#
validate_optional_fields($icq,
#
#-----[ IN-LINE FIND ]----------------------------------
#
, $signature
#
#-----[ IN-LINE AFTER, ADD ]----------------------------------
#
, $map_center, $phoocomm
Save upload and install with EM.

- Poomie
BassFace
Registered User
Posts: 5
Joined: Sun Mar 04, 2007 9:57 pm
Location: Aurora, CO
Contact:

SOLVED Issue with '#' Character

Post by BassFace »

Turns out EasyMOD can handle the '#' character, just not at the beginning of a line.
I changed this:

Code: Select all

<style>
#phoogleMap
to this

Code: Select all

<style>
    #phoogleMap
and EasyMOD installed my MOD perfectly! 8)
Locked