[PHPBB3-15580] Double setting in ACP?

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
3Di
Registered User
Posts: 734
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

[PHPBB3-15580] Double setting in ACP?

Post by 3Di » Wed Mar 07, 2018 3:54 am

https://tracker.phpbb.com/browse/PHPBB3-15580

As per the ticket. Is there a reason why?

Should one of those be removed, which one in case?

Edit: At the end of all a lot of settings are duplicated there I can see, still wondering why.
acp_double settings.png
Want to compensate me for my interest? Don't ask me, just do it
I'm available for custom phpBB jobs, you can PM me the details.
New: my Live Board, Extensions and Tools for phpBB - Men at works.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1781
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [PHPBB3-15580] Double setting in ACP?

Post by DavidIQ » Wed Mar 07, 2018 8:34 pm

Because we love redundancy? Just send a patch to remove the duplicated Load Settings section from Board Settings.
Image

User avatar
3Di
Registered User
Posts: 734
Joined: Tue Nov 01, 2005 9:50 pm
Location: Milano (I) Frankfurt (D)
Contact:

Re: [PHPBB3-15580] Double setting in ACP?

Post by 3Di » Thu Mar 08, 2018 1:46 am

I edited the ticket to better reflect the situation.

There are a lot of extra settings in ACP, visible in the attachment I above posted, all of those are already in the case 'load': of the related PHP file.

The code is located here:
https://github.com/phpbb/phpbb/blob/c70 ... #L103-L110

The value (as of now) of this topic (and prior to make a PR) is to understand if the above code should be removed for 3.3 or 3.2, basically.

Thx.

Edit: done https://github.com/phpbb/phpbb/pull/5155 (Uff, last try).
Want to compensate me for my interest? Don't ask me, just do it
I'm available for custom phpBB jobs, you can PM me the details.
New: my Live Board, Extensions and Tools for phpBB - Men at works.

Post Reply