PHPBB3-14740 BBCode still parses wrong

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
neufke
Registered User
Posts: 56
Joined: Thu Jan 02, 2014 10:08 am

PHPBB3-14740 BBCode still parses wrong

Post by neufke » Mon Jan 09, 2017 12:04 pm

Hi all,

https://tracker.phpbb.com/browse/PHPBB3-14740

Marc wrote a fix for this and i am very grateful but testing now and rewriting some extensions and i am noticing that, again, new messages aren't parsed correctly when using quotes in BBCodes while the OLD bbcodes were parsed correctly.

Now, what's the best course of action? Is this simply another bug (@Marc, i haven't found a way to set the unverified fix to "not working correctly") or am i on a "wild goose chase" with my "quotes in a BBCode". Any thoughts would be highly appreciated...

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1732
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-14740 BBCode still parses wrong

Post by DavidIQ » Mon Jan 09, 2017 12:57 pm

Try responding to the ticket. JoshyPHP is usually responsive to tickets that he's either watching or have to do with BBCode.
Image

User avatar
neufke
Registered User
Posts: 56
Joined: Thu Jan 02, 2014 10:08 am

Re: PHPBB3-14740 BBCode still parses wrong

Post by neufke » Mon Jan 09, 2017 1:32 pm

Thanx DavidIQ, will start with that.

Any thoughts on the quotes within the BBCodes itself?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1732
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-14740 BBCode still parses wrong

Post by DavidIQ » Mon Jan 09, 2017 1:35 pm

Actually it was JoshyPHP who authored the fix:
https://github.com/phpbb/phpbb/pull/4404

Marc simply merged it. I can imagine quotes being present in BBCodes and they're part of the "quote" BBCode so perhaps the fix just needs some more refining. The BBCode parser is relatively new so Joshy is the resident expert right now. You might also want to link back to this topic in your response.
Image

User avatar
neufke
Registered User
Posts: 56
Joined: Thu Jan 02, 2014 10:08 am

Re: PHPBB3-14740 BBCode still parses wrong

Post by neufke » Mon Jan 09, 2017 1:40 pm

Thank you for the extra feedback, will add it to the comment!

User avatar
JoshyPHP
Registered User
Posts: 350
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14740 BBCode still parses wrong

Post by JoshyPHP » Mon Jan 09, 2017 1:46 pm

neufke wrote:
Mon Jan 09, 2017 12:04 pm
Now, what's the best course of action?
Edit the old posts and re-save them so they get reparsed. You may need to add a non-space character to the post to force the update.

There isn't an easy way to force a single post to get reparsed currently. If you have many of those you may try the command line reparser.

User avatar
neufke
Registered User
Posts: 56
Joined: Thu Jan 02, 2014 10:08 am

Re: PHPBB3-14740 BBCode still parses wrong

Post by neufke » Mon Jan 09, 2017 1:59 pm

JoshyPHP wrote:
Mon Jan 09, 2017 1:46 pm
neufke wrote:
Mon Jan 09, 2017 12:04 pm
Now, what's the best course of action?
Edit the old posts and re-save them so they get reparsed. You may need to add a non-space character to the post to force the update.

There isn't an easy way to force a single post to get reparsed currently. If you have many of those you may try the command line reparser.
The OLD posts are working correctly and they got parsed correctly. It's new posts that aren't working and don't get parsed when they have a quote in the BBCode...

So

Code: Select all

[mod="neufke"]This is a modremark[/mod]
Doesn't get parsed

Code: Select all

[mod=neufke]This is a modremark[/mod]
This is...

But if i change the bbcode... i lose all old BBCodes, and it's not the only one we use.

User avatar
JoshyPHP
Registered User
Posts: 350
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14740 BBCode still parses wrong

Post by JoshyPHP » Mon Jan 09, 2017 2:27 pm

I thought you were talking about posts submitted on 3.2 but before 3.2.0. Try posting your BBCode definition and the steps to reproduce that issue because I can't reproduce it on my test board.

User avatar
neufke
Registered User
Posts: 56
Joined: Thu Jan 02, 2014 10:08 am

Re: PHPBB3-14740 BBCode still parses wrong

Post by neufke » Mon Jan 09, 2017 3:17 pm

Haven't changed anything since RC but found that in the DB the bbcode_guid and quites haven't been added/parsed...

Code: Select all

<t>[mod="neufke"]This is a modremark[/mod]</t>
And to be complete:

BBCode use:

Code: Select all

[mod="{TEXT1}"]{TEXT2}[/mod]
HTML Replacement:

Code: Select all

<div id="modremark">
	<div id="modremarkexclamation">!</div>
	<div>
		<div id="moderemarktitle">Moderatoropmerking {L_FROM}{L_COLON} {TEXT1} :</div>
		<div id="moderemarktext">{TEXT2}</div>
	</div>
</div>

User avatar
neufke
Registered User
Posts: 56
Joined: Thu Jan 02, 2014 10:08 am

Re: PHPBB3-14740 BBCode still parses wrong

Post by neufke » Mon Jan 09, 2017 4:13 pm

JoshyPHP wrote:
Mon Jan 09, 2017 2:27 pm
I thought you were talking about posts submitted on 3.2 but before 3.2.0. Try posting your BBCode definition and the steps to reproduce that issue because I can't reproduce it on my test board.
I've installed a fresh 3.2.0. board, first post with same BBCode settings...
screen.jpg

Post Reply