PHPBB3-14527 Dataloss caused by link shortening (maybe)

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by JoshyPHP » Thu Mar 10, 2016 9:50 pm

Ideally you would post that as a new topic, as it is unrelated to this one.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Thu Mar 10, 2016 10:03 pm

If the last two and a half pages of this thread realy are unrelated to this thread, then there should a moderator just split this thread. Seems better than having two threads on the same issue...
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

PHPBB3-14527 Dataloss caused by link shortening

Post by Joe User » Thu Mar 10, 2016 10:13 pm

Since there is no progress: https://tracker.phpbb.com/browse/PHPBB3-14527

@Devs: Stop implementing new features and fix this nasty showstopping bug first.


Start reading here https://area51.phpbb.com/phpBB/viewtopi ... 41#p288141
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by DavidIQ » Fri Mar 11, 2016 4:38 am

Joe User wrote:
Thu Mar 10, 2016 10:03 pm
If the last two and a half pages of this thread realy are unrelated to this thread, then there should a moderator just split this thread. Seems better than having two threads on the same issue...
I'll move the posts but you've posted links to posts that might no longer make sense so I leave that for you to fix. ;)
Image

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14527 Dataloss caused by link shortening (maybe)

Post by Joe User » Fri Mar 25, 2016 5:54 pm

The dataloss is fixed now, thanks.

But there are some more problems with link parsing left unfixed.
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14527 Dataloss caused by link shortening (maybe)

Post by JoshyPHP » Fri Mar 25, 2016 6:16 pm

What would those be?

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14527 Dataloss caused by link shortening (maybe)

Post by Joe User » Fri Mar 25, 2016 6:30 pm

Links like ftps://www.phpbb.com/ are parsed wrong.
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14527 Dataloss caused by link shortening (maybe)

Post by JoshyPHP » Fri Mar 25, 2016 7:20 pm

There's a config setting that governs which URL schemes are allowed. You can change it via CLI but I don't know how to change it otherwise. You'll need to purge your cache afterwards.

Code: Select all

./bin/phpbbcli.php config:set allowed_schemes_links "http,https,ftp,ftps"

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14527 Dataloss caused by link shortening (maybe)

Post by Joe User » Fri Mar 25, 2016 7:48 pm

Fine, but the hardcoded

Code: Select all

.*www => http://www
is the real problem.
It should be restricted to

Code: Select all

(EOL|SPACE)www
instead of

Code: Select all

.*www
Even better, just remove this buggy hardcoding entirely.
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14527 Dataloss caused by link shortening (maybe)

Post by JoshyPHP » Fri Mar 25, 2016 8:05 pm

You really need to get rid of that abrasive tone if you want people to read your comments.

Post Reply