PHPBB3-14527 Dataloss caused by link shortening (maybe)

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Tue Mar 01, 2016 7:53 pm

Original mailinglist source from which i copy+pasted the text to the forum:
https://docs.freebsd.org/cgi/getmsg.cgi ... nounce+raw
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Tue Mar 01, 2016 7:57 pm

This line from the FTP section got already broken by 3.1:

Code: Select all

     * ftp://ftp.<your_country_code>.FreeBSD.org/pub/FreeBSD
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Tue Mar 01, 2016 8:15 pm

Sorry for the spamming:
Are subjects, signatures, forumrules, forumdescriptions, contactpage, etc. using the same functions and are therefor also bitten by this bug?
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

CHItA
Development Team
Development Team
Posts: 128
Joined: Thu Mar 12, 2015 1:43 pm
Location: Budapest, Hungary

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by CHItA » Tue Mar 01, 2016 8:43 pm

Did you reverted your database and files to the previous version? If so, answering your question gets a bit more complicated, as it would be hard to tell what the bug is.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Tue Mar 01, 2016 9:08 pm

No, i'm on currently on 3.2.0 and since it's a production install i'm (currently) not planning to go back (3.1 is not compatible with PHP7).
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Wed Mar 02, 2016 10:25 am

Got another one, which might be a different bug:
My signature at my forum has links in it since years, today i checked it for this bug and found an issue on editing the signature.
Under UCP->Profile->Edit signature in the preview and in the textbox i got this (phpBB 3.2):

Code: Select all

[url=https&#58;//www&#46;rootservice&#46;org/howtos/general/getting_started&#46;html]Ist ein dedizierter Server das Richtige für mich?[/url] ¤ [url=https&#58;//www&#46;rootservice&#46;org/howtos/security/server_hacked&#46;html]Vorgehensweise bei gehacktem Server[/url]
[url=https&#58;//www&#46;rootservice&#46;org/howtos/freebsd/remote_install&#46;html]FreeBSD Remote Installation[/url] ¤ [url=https&#58;//www&#46;paypal&#46;me/JoeUser/20]PayPal.Me/JoeUser[/url]
Instead of this (phpBB 3.1):

Code: Select all

[url=https://www.rootservice.org/howtos/general/getting_started.html]Ist ein dedizierter Server das Richtige für mich?[/url] ¤ [url=https://www.rootservice.org/howtos/security/server_hacked.html]Vorgehensweise bei gehacktem Server[/url]
[url=https://www.rootservice.org/howtos/freebsd/remote_install.html]FreeBSD Remote Installation[/url] ¤ [url=https://www.paypal.me/JoeUser/20]PayPal.Me/JoeUser[/url]
So it breaks the punctations in the urls.

I'm looking today for more such cases.

EDIT: Same in ACP->User and Groups->Manage Users->Joe User->Signature
Last edited by Joe User on Wed Mar 02, 2016 10:33 am, edited 1 time in total.
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

User avatar
JoshyPHP
Registered User
Posts: 349
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by JoshyPHP » Wed Mar 02, 2016 10:33 am

Joe User wrote:
Wed Mar 02, 2016 10:25 am
So it breaks the punctations in the urls.

I'm looking today for more such cases.
Would you mind opening a new topic and/or ticket for them please? Since they're not related to this ticket it will be easier to track.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Wed Mar 02, 2016 11:05 am

JoshyPHP wrote:
Wed Mar 02, 2016 10:33 am
Joe User wrote:
Wed Mar 02, 2016 10:25 am
So it breaks the punctations in the urls.

I'm looking today for more such cases.
Would you mind opening a new topic and/or ticket for them please? Since they're not related to this ticket it will be easier to track.
Done: https://tracker.phpbb.com/browse/PHPBB3-14509
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Sun Mar 06, 2016 3:45 pm

Any progress?

This needs to be fixed more quickly since i'm not the only one bitten by this and stuck on PHP7 and therefor forced to use 3.2 in production.
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

Joe User
Registered User
Posts: 32
Joined: Mon Sep 13, 2004 10:10 am
Location: Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Joe User » Thu Mar 10, 2016 9:47 pm

Since there is no progress: https://tracker.phpbb.com/browse/PHPBB3-14527

@Devs: Stop implementing new features and fix this nasty showstopping bug first.
FreeBSD Remote InstallationPayPal.Me/JoeUser
Wings for LifeWings for Life World Run

„If there’s more than one possible outcome of a job or task,
and one of those outcomes will result in disaster or an undesirable consequence,
then somebody will do it that way.“ -- Edward Aloysius Murphy Jr.

Post Reply