PHPBB3-14323 / PHPBB3-14332 - Link shortening

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by DavidIQ » Thu Jan 14, 2016 7:49 pm

posey wrote:
Thu Jan 14, 2016 2:19 pm
I just quoted a post from KevC on phpBB.com which only contained a single (internal) url. Now the quote url isn't a link anymore, eventhough I did nothing to adjust it / edit. Just simply clicked 'Reply with quote'. Not sure if this is desired or not? Seems to me like it should still be a 'clickable' link.
Ah yes, THAT bug. It only happens when the link, shortened or not, is at the beginning of the quote, so it's not actually a bug specific to shortened links.
Image

User avatar
posey
Registered User
Posts: 7
Joined: Fri Dec 18, 2015 9:41 pm

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by posey » Thu Jan 14, 2016 9:02 pm

Ah alright, seperate issue then. Want me to open a ticket about it or is it already too well known / open ticket?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by DavidIQ » Thu Jan 14, 2016 9:41 pm

https://tracker.phpbb.com/
I believe there was a reason it couldn't be fixed in 3.1 so it was left as is until the BBCode parser was rewritten in 3.2. So unless it's still happening in 3.2 I'd leave it as is. You can quote me on that to verify. ;)
Image

User avatar
posey
Registered User
Posts: 7
Joined: Fri Dec 18, 2015 9:41 pm

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by posey » Thu Jan 14, 2016 11:44 pm

DavidIQ wrote:
Thu Jan 14, 2016 9:41 pm
https://tracker.phpbb.com/
I believe there was a reason it couldn't be fixed in 3.1 so it was left as is until the BBCode parser was rewritten in 3.2. So unless it's still happening in 3.2 I'd leave it as is. You can quote me on that to verify. ;)
I'll oblige, let's see :)

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by JoshyPHP » Tue Mar 01, 2016 7:36 pm


User avatar
Elsensee
Development Team
Development Team
Posts: 36
Joined: Sun Mar 16, 2014 1:08 pm
Location: Hamburg, Germany
Contact:

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Elsensee » Tue Mar 01, 2016 9:07 pm

JoshyPHP wrote:
Tue Mar 01, 2016 7:36 pm
@Nicofuma The 3.2.x branch differs from the 3.1.x branch. I think this line change should be reverted but I'm not familiar with the bug it was meant to fix; Reverting it would probably introduce a regression, I guess? https://tracker.phpbb.com/browse/PHPBB3-13377

https://github.com/phpbb/phpbb/blob/3.1 ... t.php#L460
https://github.com/phpbb/phpbb/blob/3.2 ... t.php#L472

https://github.com/phpbb/phpbb/blob/3.1 ... 3362-L3369
https://github.com/phpbb/phpbb/blob/3.2 ... 2730-L2737
I think, that this might indeed be cause of the bug. An extra fix might not be needed anymore now since TextReparsers shortens link when rendering not when parsing them.. right? So the code which was changed with that commit is mostly just legacy code, which will be needed to reparse the posts correctly.

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by JoshyPHP » Tue Mar 01, 2016 9:57 pm

Elsensee wrote:
Tue Mar 01, 2016 9:07 pm
I think, that this might indeed be cause of the bug. An extra fix might not be needed anymore now since TextReparsers shortens link when rendering not when parsing them.. right? So the code which was changed with that commit is mostly just legacy code, which will be needed to reparse the posts correctly.
It shortens the link's text at parsing time, but it doesn't matter here. PHPBB3-13377 changes the way old text is decoded. That affects old posts (and other text) at the time they are automatically reparsed or manually edited. In other words, it affects every piece of text posted on 3.1 regardless of the circumstances. Reverting it will reintroduce that bug but it will only affect old text, posted on 3.1. IMO it's worth it, considering the bug is low impact.

My recommendation: revert #3747 and consider PHPBB3-13377 a WONTFIX for 3.1 posts. The issue doesn't exist on 3.2 posts.

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 297
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by Nicofuma » Wed Mar 02, 2016 7:18 am

And what if we revert it on 3.2 only? It should fix the decoding issue. Right?
Member of the phpBB Development-Team
No Support via PM

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14323 / PHPBB3-14332 - Link shortening

Post by JoshyPHP » Wed Mar 02, 2016 10:31 am

Nicofuma wrote:
Wed Mar 02, 2016 7:18 am
And what if we revert it on 3.2 only? It should fix the decoding issue. Right?
I believe it will, yes. The PR was merged into master so AFAIK those commits only exist in the 3.2.x branch and master.

Post Reply