PHPBB3-14227 - Trim topic titles so it wont messup the layout

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

Post by JoshyPHP » Sat Oct 10, 2015 1:23 am

That's a presentation issue. Maybe something that can be fixed with text-overflow.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

Post by Dragosvr92 » Sat Oct 10, 2015 3:41 am

I also find it a bit messy how the post buttons (edit, report, quote) panel uses a static margin for it entirely. The forced-margin-width applies for all buttons, even those that are unavailable to the users. We could use that space for the title.
forced margin.png
But i guess that maybe we should keep the titles all at the same width...? I dont know. But it feels a bit weird.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
Arty
Registered User
Posts: 970
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

Post by Arty » Sat Oct 10, 2015 9:06 am

It is caused by using display:inline-block instead of display:inline on topic title: viewtopic.php?p=284116#p284116

Trimming is not a solution. Fixing display mode is.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123 123

Post by Dragosvr92 » Sat Oct 10, 2015 7:24 pm

Arty wrote:
Sat Oct 10, 2015 9:06 am
It is caused by using display:inline-block instead of display:inline on topic title: viewtopic.php?p=284116#p284116

Trimming is not a solution. Fixing display mode is.
Arty, The reason i proposed this wasnt because of the inline-block issue. But i did provide the image to show how long titles mess up the layout.
It was just a bonus to showing the problem.

The question still stands if we should have the title lengthen to a second line/paragraph, or just trim it to the available space on a responsive layout, and short. Show it fully in the title tag.

At the moment, i see phpbb allows the user to use 154 characters in its title. Thats okay, but even the full layout does not have the space to display it into one single line.

Also, check the title i added to this reply.... Does it look neat ? Imho, it doesnt.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

Post by DavidIQ » Sat Oct 10, 2015 7:32 pm

I don't see what's so terrible about text wrapping to the next line? That's how it should work without breaking other elements, which is how it's working now. There is also the possibility to have a really long username. Should we trim those too? As Arty said, trimming is not a solution. If something is breaking the layout then the layout needs fixing, not censoring or cutting off text.
Image

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

Post by Dragosvr92 » Sat Oct 10, 2015 7:49 pm

DavidIQ wrote:
Sat Oct 10, 2015 7:32 pm
If something is breaking the layout then the layout needs fixing, not censoring or cutting off text.
I suggested layout changes for the topic titles before, and it wasnt accepted as the users preferred the current layout as it is.
With long, large, prominent and useless repeating titles. viewtopic.php?f=81&t=45797
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

Post by DavidIQ » Sat Oct 10, 2015 7:53 pm

But the layout isn't being broken in viewtopic so whatever you're complaining about here doesn't really make sense. The one issue in viewforum is already known and will get fixed.
Image

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

Post by hanakin » Mon Oct 12, 2015 6:36 am

as DavidIQ has stated text-wrapping is part of the web it is an intended thing and does not break any layout issues. You can see wrapping all over the internet. the fact that you personally do not like it is a stylistic choice for your own forum to handle.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: PHPBB3-14227 - Trim topic titles so it wont messup the layout

Post by Dragosvr92 » Wed Oct 14, 2015 7:10 am

Okay, it is not broken. Just messed up. I guess it really doesnt make sense complaining about the great layout of the topic titles, especially on lower screen resolutions. The bellow attachment looks amazingly great.
Capture.PNG
This has nothing to do with my board. All the testing i did was on area51. I am only suggesting this based on prosilvers layout and how it should need some changes. Major ones. Until maybe sometime, someone dumps it and redesigns a better style. And remove or shring the useless repeating post-titles. :D
Previous user: TheKiller
Avatar on Memberlist 1.0.3

Post Reply