PHPBB3-13853 Cannot completey add a new profile field type

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
javiexin
Registered User
Posts: 90
Joined: Thu Dec 22, 2011 10:04 am

PHPBB3-13853 Cannot completey add a new profile field type

Post by javiexin » Tue May 19, 2015 12:11 pm

There is no way to insert potentially required code in adm/style/acp_profile.html STEP 1 (lines 106 to 128) as code is hardcoded for the existing types. Given the way profilefields work, using an event would be (in my opinion) a bad resolution to this.

A flexible schema, similar to the one used for STEP 2 (lines 141 to 146), should be used.
This would require some rewriting of the profilefields/type subsystem, including additions to type_interface and all profilefields/type/* classes.

Besides this, the interface is not very clear and poorly documented, so some enhancements and clarifications would clearly help.

Small bug with no consequences: get_field_name is not defined as part of the type_interface, yet it is required (and implemented as part of type_base).

-javiexin

User avatar
javiexin
Registered User
Posts: 90
Joined: Thu Dec 22, 2011 10:04 am

Re: PHPBB3-13853 Cannot completey add a new profile field type

Post by javiexin » Sun May 31, 2015 11:17 am

Created a PR for this.

https://github.com/phpbb/phpbb/pull/3673

-javiexin

Post Reply