[RFC] Ability to @mention specific users in posts

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 297
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: [RFC] Ability to @mention specific users in posts

Post by Nicofuma » Tue May 13, 2014 6:48 pm

more simply, the spaces are a problem: when does we stop to search for the username? Does we search for @Hi@Hi Oh@Hi Oh Great@Hi Oh Great Conflict or @Hi Oh Great Conflict with spaces?
And i don't think we can find a solution because all characters are allowed in the usernames, so we can't use something like that @'Hi Oh Great Conflict' with space
Member of the phpBB Development-Team
No Support via PM

User avatar
Master_Cylinder
Registered User
Posts: 361
Joined: Wed Jul 31, 2013 9:54 pm

Re: [RFC] Ability to @mention specific users in posts

Post by Master_Cylinder » Tue May 13, 2014 7:18 pm

If people insist on making phpBB a twitter clone, at least give admins the ability to turn off the feature completely.
These kids today...
Buy them books, send them to school and what do they do?

They eat the paste. :lol:

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Ability to @mention specific users in posts

Post by DavidIQ » Tue May 13, 2014 7:21 pm

Wouldn't it be a system much like Facebook's (or Twitter's) where a list of users is presented and you select one, with some sort of html tag appended to the selection? One knows this is happening in the background because nowadays you can tag "John Doe" and delete the "Doe" part after having selected the user. In the case of phpBB we'd present a list of users, you select the user, and then perhaps a BBCode is assigned to it whereas the user ID is referenced. Won't really mater if you change the username since the user's ID you want to mention is already attached. Then this scenario of Mr. "Oh Great Conflict" won't matter.
Image

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Ability to @mention specific users in posts

Post by imkingdavid » Wed May 14, 2014 3:31 am

How about using quotes for names that have spaces. So @"Hi Oh Great" would only match a user with the username Hi Oh Great and wouldn't match Hi or HI Oh. The quotes would be optional but if omitted it would assume the first valid username it finds. So if there is a user HI and a user Hi Oh and you do @Hi Oh it would notify Hi but if you did @"Hi oh" it would notify HI oh.

A question then, if there is no user named Hi but there is a user named Hi Oh and you did @Hi should it assume the username Hi Oh or should it be unparsed? I vote unparsed.

EDIT: Looks like I missed the last 3 posts because I didn't realize there was another page. Good point about usernames being able to have any characters. However, I think we can, at the start, allow escaping quotes (e.g. @"Say \"Hello\"" or something until we get to the point that DavidIQ was talking about. I think we should start off simple and eventually use some special tags in the background somehow.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
BioLogIn
Registered User
Posts: 28
Joined: Mon Dec 10, 2012 6:55 pm

Re: [RFC] Ability to @mention specific users in posts

Post by BioLogIn » Wed May 14, 2014 6:30 am

Just my 2 cents.

@Hi Oh@ looks better than @"Hi Oh".

IMHO.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Ability to @mention specific users in posts

Post by EXreaction » Wed May 14, 2014 10:25 pm

The idea earlier was to use bbcodes for this, e.g. [mention]some user[/mention]. To make it "nice" like how everyone else does it, since we do not use a wysiwyg editor to hide those bbcodes, we would simple make a javascript listener for when someone types @[^\s] in the text area and then pop out a username search based on what they have typed since the @ sign. Hitting esc would close the window, and selecting a user or hitting enter would replace the @ and whatever they typed with the selected user wrapped in a [mention] tag.

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] Ability to @mention specific users in posts

Post by VSE » Thu May 15, 2014 3:14 am

EXreaction wrote:The idea earlier was to use bbcodes for this, e.g. [mention]some user[/mention]. To make it "nice" like how everyone else does it, since we do not use a wysiwyg editor to hide those bbcodes, we would simple make a javascript listener for when someone types @[^\s] in the text area and then pop out a username search based on what they have typed since the @ sign. Hitting esc would close the window, and selecting a user or hitting enter would replace the @ and whatever they typed with the selected user wrapped in a [mention] tag.
I agree that this is the way to do it for phpBB. And of course when rendered in the post, it would look like @EXreaction
Has an irascible disposition.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Ability to @mention specific users in posts

Post by nickvergessen » Thu May 15, 2014 11:04 am

Well " won't work, we allow them on registration, same ofr @ and many others. So I guess a new BBCode is the only option we have.
Member of the Development-TeamNo Support via PM

User avatar
Darkness_demoN
Registered User
Posts: 89
Joined: Mon Jul 29, 2013 1:48 pm
Contact:

Re: [RFC] Ability to @mention specific users in posts

Post by Darkness_demoN » Wed Jul 02, 2014 8:41 am

http://www.canidev.com/app/?lang=en&i=c ... wer-v1.0.1

This is working mod for phpbb 3.0.11.
Also see CaniDev other mods.

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 297
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: [RFC] Ability to @mention specific users in posts

Post by Nicofuma » Wed Jul 02, 2014 9:00 am

this mod does not use a custom bbcode, and it disallows the usernames with spaces, <> or []
Member of the phpBB Development-Team
No Support via PM

Post Reply