[RFC] Ability to @mention specific users in posts

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
dellsystem
Registered User
Posts: 13
Joined: Tue May 22, 2007 12:10 am

[RFC] Ability to @mention specific users in posts

Post by dellsystem » Tue Apr 10, 2012 8:46 pm

Ticket: PHPBB3-13713
PR:
--------------------

Feature description

It would be nice to have a @mention feature, akin to what Twitter, Github, Facebook et al. have. The behaviour I had in mind is this: you start typing @someusername and a small window pops up showing possible usernames (maybe up to 10). When you submit the post, the username is linked to the user's profile.

For example, if I typed @naderman, it would turn into a link to his user profile (like this: @naderman) and he would get a PM or email (if enabled in his profile settings) alerting him about the topic. The extra JS-based functionality would be nice if JS is enabled, but would not be necessary for the feature to work - with JS disabled, no window would pop up, but mentioning a user would still link to their profile.

Caveats
  • Open to abuse - what if I posted a hundred times and mentioned @naderman every single time, resulting in a hundred notifications for naderman? How can this be avoided?
Implementation details - to be discussed
  • Editing posts - deleting @mentions should probably not do anything. What about adding a mention? What if you delete then subsequently add a mention?
  • How should the mention data be stored? Or should it just not be stored at all? (In which case, how would it work in conjunction with the ability to add/delete mention?) Should it be stored on a per-post basis, with mentions that have been deleted from the post not deleted from the table to avoid users being notified about one post multiple times? Should it be on a per-topic basis?
Latest updates
- A new [mention][/mention] bbcode
- A new popup-up when you start writing @ after a space if you are in WYSIWYG mode
- @mention parsed automatically when the post is submitted (with a checkbox and an option to disable it, like for the smileys)

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Ability to @mention specific users in posts

Post by callumacrae » Tue Apr 10, 2012 8:51 pm

+1 so much!

When a post is first posted, all @names should be replaced with [url=etc and the user notified. From then on in any edits etc, they should not be notified (even if they add an @). This will prevent stuff like quoted posts notifying the user, too.


In order to prevent abuse, why not send a PM when a user is mentioned? If it is done properly, then I could add some as a foe (that blocks PMs from them, right?) and then would not receive any more mention spam from them.
Made by developers, for developers!
My blog

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Ability to @mention specific users in posts

Post by DavidIQ » Tue Apr 10, 2012 10:12 pm

PMs for this would be good. I like the idea overall. This could then be plug-in-able so that if an admin installs some sort of global instant chat the mention would come up on it.
Image

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Ability to @mention specific users in posts

Post by MichaelC » Tue Apr 10, 2012 10:18 pm

+1, I was actually thinking about how to implement this on phpbb.com for team members usage, while I was in the shower about a week ago.

Only 1 mention per user per post and a permission would stop abuse.

I don't think it needs any storage, just if a post contains @ followed by a valid username (unless in (urg I can't put code tags inside a code tag)) it will be changed to

Code: Select all

[url=userprofile]@username[/url]
and a pm would be made (which would be stored as a normal pm).

Edits wont notify the users.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Ability to @mention specific users in posts

Post by callumacrae » Tue Apr 10, 2012 10:21 pm

You can put [code][/code] tags in [c][/c] tags, if that is what you meant.
Made by developers, for developers!
My blog

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Ability to @mention specific users in posts

Post by MichaelC » Tue Apr 10, 2012 10:23 pm

callumacrae wrote:You can put [code][/code] tags in [c][/c] tags, if that is what you meant.
Oh, on phpbb.com [c][/c] doesn't stop parsing.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] Ability to @mention specific users in posts

Post by jsebean » Tue Apr 10, 2012 10:53 pm

+1 +1 +1 I myself was considering to make an RFC for this after I saw on the bukkit forums (they make open source minecraft server with plugin API) someone did that and someone else got a notification. Would be really awesome if phpBB had it because I thought the idea was awesome.
-Jonah

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] Ability to @mention specific users in posts

Post by AliasM2K » Wed Apr 11, 2012 1:23 am

dellsystem wrote:Feature description

It would be nice to have a @mention feature, akin to what Twitter, Github, Facebook et al. have. The behaviour I had in mind is this: you start typing @someusername and a small window pops up showing possible usernames (maybe up to 10). When you submit the post, the username is linked to the user's profile.

For example, if I typed @naderman, it would turn into a link to his user profile (like this: @naderman) and he would get a PM or email (if enabled in his profile settings) alerting him about the topic. The extra JS-based functionality would be nice if JS is enabled, but would not be necessary for the feature to work - with JS disabled, no window would pop up, but mentioning a user would still link to their profile.

Caveats
  • Open to abuse - what if I posted a hundred times and mentioned @naderman every single time, resulting in a hundred notifications for naderman? How can this be avoided?
Implementation details - to be discussed
  • Editing posts - deleting @mentions should probably not do anything. What about adding a mention? What if you delete then subsequently add a mention?
  • How should the mention data be stored? Or should it just not be stored at all? (In which case, how would it work in conjunction with the ability to add/delete mention?) Should it be stored on a per-post basis, with mentions that have been deleted from the post not deleted from the table to avoid users being notified about one post multiple times? Should it be on a per-topic basis?
Really love the idea :)

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Ability to @mention specific users in posts

Post by brunoais » Wed Apr 11, 2012 5:31 am

Even though I like the idea.
I still wonder if this should be an extension or a feature in the core. As many people like it, seems like it can happily live in the core.
Another thing. Personally I wouldn't like to have this kind of PM mixedup with the rest of the PMs, I'd rather have a folder specially made for these warnings. I think you should take that in mind while implementing this feature, don't force the user to receive the PM about this in the inbox, allow him to choose the folder to receive this.

User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

Re: [RFC] Ability to @mention specific users in posts

Post by Erik Frèrejean » Wed Apr 11, 2012 11:05 am

brunoais wrote:Personally I wouldn't like to have this kind of PM mixedup with the rest of the PMs, I'd rather have a folder specially made for these warnings. I think you should take that in mind while implementing this feature, don't force the user to receive the PM about this in the inbox, allow him to choose the folder to receive this.
^ that.
There should be some sort of "notification" box which is used for these kind of notifications. I don't think that the end user should be able to chose, just add a new special box for these kind of notifications.
Available on .com
Support Toolkit developer

Post Reply