PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by brunoais » Fri Sep 16, 2016 5:51 am


User avatar
CarpCharacin
Registered User
Posts: 55
Joined: Fri Mar 18, 2016 4:49 am

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by CarpCharacin » Fri Sep 16, 2016 6:02 am

brunoais wrote:
Fri Sep 16, 2016 5:51 am
https://github.com/phpbb/phpbb/pull/3630
Demo: http://brunoaisserver.dtdns.net/phpbbWYSIWYG/ (server not online all the time. Be patient)
Is that in the core? The pull request is closed. Do you plan to continue work on it? Can I help? I would really like to see this merged into 3.3.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by brunoais » Fri Sep 16, 2016 10:12 pm

No, yes, yes, ok.

User avatar
CarpCharacin
Registered User
Posts: 55
Joined: Fri Mar 18, 2016 4:49 am

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by CarpCharacin » Fri Sep 16, 2016 11:20 pm

The server was offline last night and it is still offline.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by DavidIQ » Fri Sep 16, 2016 11:33 pm

CarpCharacin wrote:
Fri Sep 16, 2016 11:20 pm
The server was offline last night and it is still offline.
That's not needed anyways. All of his code is in the closed pull request. If you're wanting to help with the code that is where you need to get it from.
Image

User avatar
CarpCharacin
Registered User
Posts: 55
Joined: Fri Mar 18, 2016 4:49 am

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by CarpCharacin » Sun Sep 18, 2016 2:22 am

What needs to be changed in the code? I would like to see a demo of it.

User avatar
CarpCharacin
Registered User
Posts: 55
Joined: Fri Mar 18, 2016 4:49 am

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by CarpCharacin » Mon Sep 19, 2016 4:03 am

The demo is working and I like it. Why is the pull request closed? What work still needs to be done on it? Also, why did you remove the icons on the editor bar? I think that we should try to keep the integration as simple as possible to make upgrades to newer versions of the editor easier.

User avatar
Meis2M
Registered User
Posts: 411
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by Meis2M » Mon Sep 19, 2016 7:26 am

i think ckeditor and tinymce is best for phpBB because of support of these editors and new versions and there are many people working on that.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by DavidIQ » Mon Sep 19, 2016 11:46 am

CarpCharacin wrote:
Mon Sep 19, 2016 4:03 am
Why is the pull request closed?
I don't know why you keep asking this. You commented on the pull request so I assume you read all comments there and are aware there are still some items to be worked on, you commented in this topic so you know the comments by the pull request author, who has stated numerous times he is unable to work on the code to finish it, and has not worked on the pull request in over a year. To quelch your thirst for information: Keeping a pull request open for that long will mean it is unable to be merged so there is little reason to keep it open.
Image

User avatar
CarpCharacin
Registered User
Posts: 55
Joined: Fri Mar 18, 2016 4:49 am

Re: PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Post by CarpCharacin » Tue Sep 20, 2016 2:13 am

I am not quite sure what templates to put the SCE code into. I plan to have the editor files in /editor/.

Post Reply