PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Current releases are 3.2/Rhea and 3.3/Proteus.
Post Reply
User avatar
John P
Posts: 157
Joined: Sun Nov 04, 2012 7:39 am
Location: Netherlands
Contact:

Re: WYSIWYG Editor/Rich Text Editor

Post by John P »

Are we getting a wysiwyg editor?
I really don't hope so. For years it was not possible and dangerous and now we are getting one.
Please don't!

User avatar
BioLogIn
Registered User
Posts: 28
Joined: Mon Dec 10, 2012 6:55 pm

Re: WYSIWYG Editor/Rich Text Editor

Post by BioLogIn »

John P
Just turn it off then...

User avatar
Master_Cylinder
Registered User
Posts: 361
Joined: Wed Jul 31, 2013 9:54 pm

Re: WYSIWYG Editor/Rich Text Editor

Post by Master_Cylinder »

BioLogIn wrote:John P
Just turn it off then...
A better idea would be to use an extension to add one, imho... :D
These kids today...
Buy them books, send them to school and what do they do?

They eat the paste. :lol:

User avatar
John P
Posts: 157
Joined: Sun Nov 04, 2012 7:39 am
Location: Netherlands
Contact:

Re: WYSIWYG Editor/Rich Text Editor

Post by John P »

I agree with Master Cylinder.
In that way people can choose which editor and who doesn't want doesn't have the ballast.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1856
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: WYSIWYG Editor/Rich Text Editor

Post by DavidIQ »

It's not quite that simple. We can either have one that works well or many that could be crappy, have hidden security vulnerabilities, or don't work right in which case you'd be at the mercy of the extension developer who may or may not fix it. I think the former would be a better choice.
Image

User avatar
Master_Cylinder
Registered User
Posts: 361
Joined: Wed Jul 31, 2013 9:54 pm

Re: WYSIWYG Editor/Rich Text Editor

Post by Master_Cylinder »

DavidIQ wrote:It's not quite that simple. We can either have one that works well or many that could be crappy, have hidden security vulnerabilities, or don't work right in which case you'd be at the mercy of the extension developer who may or may not fix it. I think the former would be a better choice.
It could be an official extension though...that keeps the people that don't want it from having the bloat and keeps it properly updated.
These kids today...
Buy them books, send them to school and what do they do?

They eat the paste. :lol:

User avatar
JoshyPHP
Registered User
Posts: 376
Joined: Fri Jul 08, 2011 9:43 pm

Re: WYSIWYG Editor/Rich Text Editor

Post by JoshyPHP »

But making everything an extension is bloat. Extensions are not magic, they need an API or some sort of interface. They might need events and hooks and an interface to the database. This increases phpBB's complexity and this increases the extension's complexity. Extensions have a cost even when you don't use them.

In compiled software, making highly modular projects can be a good thing because the unused code is optimized away and a lot of the overhead can be optimized away/inlined. This is not the case in PHP.

User avatar
Master_Cylinder
Registered User
Posts: 361
Joined: Wed Jul 31, 2013 9:54 pm

Re: WYSIWYG Editor/Rich Text Editor

Post by Master_Cylinder »

Not "everything" needs to be an extension but THIS would be less of a cost than putting it in the core and not using it, right?
These kids today...
Buy them books, send them to school and what do they do?

They eat the paste. :lol:

User avatar
JoshyPHP
Registered User
Posts: 376
Joined: Fri Jul 08, 2011 9:43 pm

Re: WYSIWYG Editor/Rich Text Editor

Post by JoshyPHP »

It's impossible for me to say because I don't know how phpBB's extensions work and what people have in mind when they're talking about an RTE.

From my point of view, a RTE is almost entirely a client-side thing. Have it as a template bit, include it in the posting template in a conditional. The only server-side thing would be a switch somewhere in the user's profile for enabling it, the setting being stored in phpbb_users.user_options or some other bitfield. The only overhead then is to assign a variable to represent the setting in the posting template, and an extra "if" in the posting template.

In that example, the RTE would receive the post as HTML except for custom BBCodes that I would keep as-is. I don't know what the other posters in this topic have in mind, it might be entirely different. And this is assuming the RTE can convert its HTML back to BBCodes too.

User avatar
Master_Cylinder
Registered User
Posts: 361
Joined: Wed Jul 31, 2013 9:54 pm

Re: WYSIWYG Editor/Rich Text Editor

Post by Master_Cylinder »

As complicated as this is, I imagine the bloat could be substantial but I could be wrong about that. Either way a large number of admins don't want wysisyg and most posts are simple text so I still think this would be better as an official extension. Not that I have a choice or a say in the matter. ;)
These kids today...
Buy them books, send them to school and what do they do?

They eat the paste. :lol:

Post Reply