PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor

Discuss requests for comments/changes posted in the Issue Tracker for the development of phpBB. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
demon326
Registered User
Posts: 17
Joined: Sat Mar 20, 2010 9:29 am

Re: [RFC] WYSIWYG Editor

Post by demon326 » Thu Jan 12, 2012 5:18 pm

callumacrae wrote:EDIT: I think CKEditor is ugly, though :-(
http://www.kunstmaan.be/blog/2012/01/03 ... -ckeditor/

Try this nice skin :)

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] WYSIWYG Editor

Post by callumacrae » Thu Jan 12, 2012 8:16 pm

demon326 wrote:
callumacrae wrote:EDIT: I think CKEditor is ugly, though :-(
http://www.kunstmaan.be/blog/2012/01/03 ... -ckeditor/

Try this nice skin :)
That isn't bad. I don't like the massive amount of buttons it has, and I can't see the point in the top row of them.
Made by developers, for developers!
My blog

demon326
Registered User
Posts: 17
Joined: Sat Mar 20, 2010 9:29 am

Re: [RFC] WYSIWYG Editor

Post by demon326 » Fri Jan 13, 2012 1:45 pm

callumacrae wrote:
demon326 wrote:
callumacrae wrote:EDIT: I think CKEditor is ugly, though :-(
http://www.kunstmaan.be/blog/2012/01/03 ... -ckeditor/

Try this nice skin :)
That isn't bad. I don't like the massive amount of buttons it has, and I can't see the point in the top row of them.
they just enabled the full editor to show the skin, you can turn off buttons you don't need :)

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] WYSIWYG Editor

Post by jsebean » Fri Jan 13, 2012 6:48 pm

DavidIQ wrote:
jsbean wrote:From discussions and comments I've seen, CK folks seemed to not have the people to develop this and think it should be responsibility of phpBB devs. Any updates on the progress of this?

ETA: http://cksource.com/forums/viewtopic.ph ... b&start=10
I'm not sure how you came to that conclusion. This ticket says they've coded a BBCode parser and looks to have been merged to their main branch:
http://dev.ckeditor.com/ticket/7044

About a month ago there was also a MOD submitted for 3.0.9 (denied):
http://www.phpbb.com/customise/db/mod/ckeditor/

So it's apparently already possible with the current CKEditor release.
Thought I read it somewhere, the conclusion by someone I was repeating but maybe I made it right up :lol: ... guess this confirmed I made it up? :lol:
wGEric wrote:I would suggest calling this a Rich Text Editor instead of a WYSIWYG. More than likely it won't be a true WYSIWYG.
Sounds good :D
-Jonah

wiktor
Registered User
Posts: 7
Joined: Tue May 24, 2011 12:05 pm

Re: [RFC] WYSIWYG Editor

Post by wiktor » Tue Mar 06, 2012 11:05 am

I can confirm what DavidIQ already wrote. We are interested in helping anyone willing to add Rich Text Editor to phpBB if the phpBB team decides to introduce this feature.
One of the examples that shows that we are really serious ;) is the sample BBCode parser that we introduced in CKEditor 3.6 - http://dev.ckeditor.com/ticket/7044 (see the live demo).

By creating this sample, we wanted to show that:
  • CKEditor is capable of producing BBCode output (and any other custom syntax)
  • In case of any problems, we can offer the required support
    (e.g when you face a problem that can be solved only by changing something in the CKEditor core, we can add changes to the CKEditor).
Fredck wrote only that we are unable to handle this integration task by ourself. It means that we cannot work directly on the PHP or JavaScript code for phpBB 3.2/4.0 and simply provide a ready solution. It must be done by someone that comes from the phpBB team, that knows phpBB well and at the same time by someone, that is an experienced JavaScript developer, to feel comfortable while working with JavaScript.

Regarding the skin - as someone already pointed out, there are other skins to choose from and last but not least, one of the options to consider would be to create a dedicated skin for phpBB.

Regarding the interface - it should be technically possible to resign from CKEditor toolbar and attach specific actions to the current interface.
In such case, the buttons above the textarea (, , and so on) would stay as is and the textarea would behave like the contenteditable area (e.g. Ctrl+B shortcut will work, the context menu will be available). Pressing the button would of course make the text bold just like in CKEditor.
I'm just mentioning to write that it should be technically possible, personally I'd rather avoid it to better distinguish the WYSIWYG mode and plain text mode in phpBB. Also the built-in toolbar offers accessibility support (using WAI-ARIA), so instead of removing it, a dedicated skin sounds like a better option.
CTO, CKSource
http://ckeditor.com/

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] WYSIWYG Editor

Post by callumacrae » Tue Mar 06, 2012 12:22 pm

I'd be willing to work on this. Having looked at CKEditor some more, I have realised that the only bad thing is the default skin, which can be easily changed anyway.

Not a huge fan of your coding standards, though :P
Made by developers, for developers!
My blog

wiktor
Registered User
Posts: 7
Joined: Tue May 24, 2011 12:05 pm

Re: [RFC] WYSIWYG Editor

Post by wiktor » Tue Mar 06, 2012 1:13 pm

callumacrae wrote:I'd be willing to work on this.
Sounds great :)

I'm curious what phpBB Management/Development Team plans are...
CTO, CKSource
http://ckeditor.com/

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] WYSIWYG Editor

Post by callumacrae » Tue Mar 06, 2012 8:44 pm

<callumacrae> igorw: Can I do CKEditor?
<@igorw> callumacrae: yeah, would be cool if you somebody could pick that up
Made by developers, for developers!
My blog

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] WYSIWYG Editor

Post by brunoais » Tue Mar 06, 2012 10:25 pm

Just a note/warning:
By default, as it works now, the buttons in the CKEditor do not work while viewing/editing the source code.
That will probably cause ppl to complain that while they are writting it "hard core" the buttons won't work.

Basically just let it work with its current WYSIWYG system and also make the buttons work while seeing the "source code" (the text with BBCode)
else we should get an alternate solution.
A possible solution is to make a changer between what we have now and the CKEditor itself.

(adapted from conversation in IRC)

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 788
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] WYSIWYG Editor

Post by hanakin » Wed Mar 07, 2012 4:11 am

brunoais wrote:Just a note/warning:
By default, as it works now, the buttons in the CKEditor do not work while viewing/editing the source code.
That will probably cause ppl to complain that while they are writting it "hard core" the buttons won't work.

Basically just let it work with its current WYSIWYG system and also make the buttons work while seeing the "source code" (the text with BBCode)
else we should get an alternate solution.
A possible solution is to make a changer between what we have now and the CKEditor itself.

(adapted from conversation in IRC)
I would alos default to the code or source mode

Post Reply