Are we getting a wysiwyg editor?
I really don't hope so. For years it was not possible and dangerous and now we are getting one.
Please don't!
PHPBB3-10418 - WYSIWYG Editor/Rich Text Editor
Re: WYSIWYG Editor/Rich Text Editor
John P
Just turn it off then...
Just turn it off then...
- Master_Cylinder
- Registered User
- Posts: 361
- Joined: Wed Jul 31, 2013 9:54 pm
Re: WYSIWYG Editor/Rich Text Editor
A better idea would be to use an extension to add one, imho...BioLogIn wrote:John P
Just turn it off then...
These kids today...
Buy them books, send them to school and what do they do?
They eat the paste.
Buy them books, send them to school and what do they do?
They eat the paste.
Re: WYSIWYG Editor/Rich Text Editor
I agree with Master Cylinder.
In that way people can choose which editor and who doesn't want doesn't have the ballast.
In that way people can choose which editor and who doesn't want doesn't have the ballast.
- DavidIQ
- Customisations Team Leader
- Posts: 1904
- Joined: Thu Mar 02, 2006 4:29 pm
- Location: Earth
- Contact:
Re: WYSIWYG Editor/Rich Text Editor
It's not quite that simple. We can either have one that works well or many that could be crappy, have hidden security vulnerabilities, or don't work right in which case you'd be at the mercy of the extension developer who may or may not fix it. I think the former would be a better choice.
- Master_Cylinder
- Registered User
- Posts: 361
- Joined: Wed Jul 31, 2013 9:54 pm
Re: WYSIWYG Editor/Rich Text Editor
It could be an official extension though...that keeps the people that don't want it from having the bloat and keeps it properly updated.DavidIQ wrote:It's not quite that simple. We can either have one that works well or many that could be crappy, have hidden security vulnerabilities, or don't work right in which case you'd be at the mercy of the extension developer who may or may not fix it. I think the former would be a better choice.
These kids today...
Buy them books, send them to school and what do they do?
They eat the paste.
Buy them books, send them to school and what do they do?
They eat the paste.
Re: WYSIWYG Editor/Rich Text Editor
But making everything an extension is bloat. Extensions are not magic, they need an API or some sort of interface. They might need events and hooks and an interface to the database. This increases phpBB's complexity and this increases the extension's complexity. Extensions have a cost even when you don't use them.
In compiled software, making highly modular projects can be a good thing because the unused code is optimized away and a lot of the overhead can be optimized away/inlined. This is not the case in PHP.
In compiled software, making highly modular projects can be a good thing because the unused code is optimized away and a lot of the overhead can be optimized away/inlined. This is not the case in PHP.
- Master_Cylinder
- Registered User
- Posts: 361
- Joined: Wed Jul 31, 2013 9:54 pm
Re: WYSIWYG Editor/Rich Text Editor
Not "everything" needs to be an extension but THIS would be less of a cost than putting it in the core and not using it, right?
These kids today...
Buy them books, send them to school and what do they do?
They eat the paste.
Buy them books, send them to school and what do they do?
They eat the paste.
Re: WYSIWYG Editor/Rich Text Editor
It's impossible for me to say because I don't know how phpBB's extensions work and what people have in mind when they're talking about an RTE.
From my point of view, a RTE is almost entirely a client-side thing. Have it as a template bit, include it in the posting template in a conditional. The only server-side thing would be a switch somewhere in the user's profile for enabling it, the setting being stored in phpbb_users.user_options or some other bitfield. The only overhead then is to assign a variable to represent the setting in the posting template, and an extra "if" in the posting template.
In that example, the RTE would receive the post as HTML except for custom BBCodes that I would keep as-is. I don't know what the other posters in this topic have in mind, it might be entirely different. And this is assuming the RTE can convert its HTML back to BBCodes too.
From my point of view, a RTE is almost entirely a client-side thing. Have it as a template bit, include it in the posting template in a conditional. The only server-side thing would be a switch somewhere in the user's profile for enabling it, the setting being stored in phpbb_users.user_options or some other bitfield. The only overhead then is to assign a variable to represent the setting in the posting template, and an extra "if" in the posting template.
In that example, the RTE would receive the post as HTML except for custom BBCodes that I would keep as-is. I don't know what the other posters in this topic have in mind, it might be entirely different. And this is assuming the RTE can convert its HTML back to BBCodes too.
- Master_Cylinder
- Registered User
- Posts: 361
- Joined: Wed Jul 31, 2013 9:54 pm
Re: WYSIWYG Editor/Rich Text Editor
As complicated as this is, I imagine the bloat could be substantial but I could be wrong about that. Either way a large number of admins don't want wysisyg and most posts are simple text so I still think this would be better as an official extension. Not that I have a choice or a say in the matter.
These kids today...
Buy them books, send them to school and what do they do?
They eat the paste.
Buy them books, send them to school and what do they do?
They eat the paste.