[RFC] Integrate s9e\TextFormatter

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.2/Rhea branch. Everything listed in this forum will be available in phpBB 3.2.
Post Reply
User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Integrate s9e\TextFormatter

Post by Pony99CA » Fri Mar 27, 2015 2:11 am

Do the event names really need "s9e" in them? Technology names shouldn't be in events, should they? For example, isn't core.text_formatter_configure_before good enough?

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: [RFC] Integrate s9e\TextFormatter

Post by JoshyPHP » Fri Mar 27, 2015 2:43 am

No, because there's no universal API to code against. The core.text_formatter_s9e_configure_before event gives you an instance of s9e\TextFormatter\Configurator and then you use its API.

Nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 297
Joined: Sun Apr 13, 2014 1:40 am
Location: Paris

Re: [RFC] Integrate s9e\TextFormatter

Post by Nicofuma » Sun Apr 05, 2015 10:21 pm

Merged, but we still have a lot of things to do (new tickets/new PRs :))
  • Add a cron job to silently reparse all the posts
  • Design an API/Interface for the whole text formatting thingy (I mean: replace generate_text_for_*, includes/bbcode.php and includes/message_parser.php)
  • At least make includes/message_parser.php autoloadable
  • We don't want to fix message_parser to be PHP7 compatible, so we need to reparse the posts on the fly (if needed) when we try to display them.
Member of the phpBB Development-Team
No Support via PM

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: [RFC] Integrate s9e\TextFormatter

Post by JoshyPHP » Mon Apr 06, 2015 7:04 pm

Great news.
Nicofuma wrote:Merged, but we still have a lot of things to do (new tickets/new PRs :))
Indeed. I would be great if you'd create a thread for each of those to get the discussion started. Also useful: an outline of your timetable for those, or perhaps rather which version(s) you want to target.

I have looked into using cron to convert posts in the background. The conversion itself is simple (load/unparse/reparse/save) but the last time I looked into it I identified at least 9 different places where rich text is stored. The task is not as straightforward as it may seem at first glance. I have more thoughts on the matter that I'll share in the relevant topic. I haven't fleshed them out in the form of working code but there's a good chance I'll take over that task.

As for the rest of the bullet points I don't have much insight.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Integrate s9e\TextFormatter

Post by brunoais » Mon Jul 06, 2015 9:03 pm

A post was made in this topic... where is it?

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: [RFC] Integrate s9e\TextFormatter

Post by JoshyPHP » Mon Jul 06, 2015 9:07 pm


User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Integrate s9e\TextFormatter

Post by brunoais » Tue Jul 07, 2015 1:11 pm

Thank you.

Hunchman801
Registered User
Posts: 12
Joined: Fri Sep 11, 2015 12:55 pm

Re: [RFC] Integrate s9e\TextFormatter

Post by Hunchman801 » Wed Sep 30, 2015 11:26 am

Great job, this really is a huge step forward.

I understand this fixes custom BBCode nesting, such as:

Code: Select all

[spoiler][spoiler]text[/spoiler][/spoiler]
But does it also prevent it from breaking the page layout, as can be done with the following:

Code: Select all

[quote][spoiler][/quote][/spoiler]
In that case, which tag(s) would be processed? Quote, spoiler, or none?

Note: I know spoiler's not standard but this happens with every single implementation of it, it's basically just a div.

User avatar
JoshyPHP
Registered User
Posts: 348
Joined: Fri Jul 08, 2011 9:43 pm

Re: [RFC] Integrate s9e\TextFormatter

Post by JoshyPHP » Wed Sep 30, 2015 4:19 pm

Off the top of my head, it would be interpreted as the following:

Code: Select all

[quote][spoiler][/spoiler][/quote][/spoiler]
The spoiler div stops at the end of the quote and you see a lone, unused [/spoiler] BBCode after the quote.

xiri
Registered User
Posts: 3
Joined: Sun Nov 06, 2016 10:27 am

Re: [RFC] Integrate s9e\TextFormatter

Post by xiri » Sun Nov 06, 2016 10:29 am

Hello.
Help me to understand why different versions of phpbb differently write data into the database. For example:

3.1:

Code: Select all

[quote:3olk12uy]123цитата[/quote:3olk12uy]

3.2:

Code: Select all

<r><QUOTE><s>[quote]</s>123цитата <e>[/quote]</e></QUOTE></r>


Why 3.2 version of parsing is better?
Thanks in advance!

Post Reply