[RFC] Remove innermost quote

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.2/Rhea branch. Everything listed in this forum will be available in phpBB 3.2.
User avatar
emosbat
Registered User
Posts: 43
Joined: Fri Aug 24, 2012 8:49 am

Re: [RFC] Remove innermost quote

Post by emosbat » Sat May 11, 2013 7:31 am

bantu wrote:This only works for full quotes using the quote button, otherwise we do want to tamper with user data because the quotes may contain external content which we should certainly not just throw away.
all quotes come from posts in topic so user can find them there.
/
+1 for RFC currently using a mod for this.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Remove innermost quote

Post by bantu » Mon May 13, 2013 1:28 am

emosbat wrote:all quotes come from posts in topic so user can find them there.
That
is
just
not
true.
The Quote-BBcode is for quoting. You can quote external sources and quotes can contain other quotes. E.g. when copying discussions from one board (e.g. limit is 5) to another (e.g. limit is 3), content should certainly not be silently thrown away, but an error message should be shown. But surely when quoting another post using one of the post buttons removing the innermost qoutes can be considered.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Remove innermost quote

Post by EXreaction » Mon May 13, 2013 5:29 am

What was the original intention for having limits on the number of nested quotes? Why do we still have the limit?

User avatar
emosbat
Registered User
Posts: 43
Joined: Fri Aug 24, 2012 8:49 am

Re: [RFC] Remove innermost quote

Post by emosbat » Mon May 13, 2013 8:32 am

bantu wrote:
emosbat wrote:all quotes come from posts in topic so user can find them there.
That
is
just
not
true.
The Quote-BBcode is for quoting. You can quote external sources and quotes can contain other quotes. E.g. when copying discussions from one board (e.g. limit is 5) to another (e.g. limit is 3), content should certainly not be silently thrown away, but an error message should be shown. But surely when quoting another post using one of the post buttons removing the innermost qoutes can be considered.
your example is so infrequent. I didn't had such problem in vB boards that remove extra qoutes automatically (7 years user of many forums). and one note is that such function should remove extra quote from within topic, we can detect what quote is from a post (quote="bantu" is from a post etc.) and what is from outside or a user made (quote without username, or multi-qoutes submiting from editor). but of course it should be an option.

User avatar
paulus
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 361
Joined: Thu Sep 16, 2004 9:02 am
Contact:

Re: [RFC] Remove innermost quote

Post by paulus » Mon May 13, 2013 11:50 am

https://www.google.nl/ wrote:Not from a post
Still not true ;)
Image

User avatar
emosbat
Registered User
Posts: 43
Joined: Fri Aug 24, 2012 8:49 am

Re: [RFC] Remove innermost quote

Post by emosbat » Mon May 13, 2013 5:52 pm

paulus wrote:
https://www.google.nl/ wrote:Not from a post
Still not true ;)
well I do not see point of a multi-qoute from google until google reply to that post :P

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Remove innermost quote

Post by callumacrae » Mon May 13, 2013 6:22 pm

EXreaction wrote:What was the original intention for having limits on the number of nested quotes? Why do we still have the limit?
If you nest too far, it is both tricky to read and about 20 pixels wide.
Made by developers, for developers!
My blog

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Remove innermost quote

Post by EXreaction » Mon May 13, 2013 10:08 pm

That's really dependent on the browser width and might become more of an issue if we move to a design that doesn't have a minimum width and is more responsive.

A better way to fix that problem might be to change the user interface (modify the css that displays it or use some javascript to hide quotes that are too deep depending on the browser width), not use hard limits or delete post content.

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 789
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Remove innermost quote

Post by hanakin » Mon May 13, 2013 10:17 pm

problem with that is you would still be serving it all on mobile, while yes the spacing would be smaler you are stil going to be limited very quickly on a mobile theme in the number of quotes. so it should be handled through the core rather than css or js to prevent all the unnecessary rendering on mobile of hidden contents

User avatar
A_Jelly_Doughnut
Registered User
Posts: 1780
Joined: Wed Jun 04, 2003 4:23 pm

Re: [RFC] Remove innermost quote

Post by A_Jelly_Doughnut » Wed May 29, 2013 12:10 am

callumacrae wrote: If you nest too far, it is both tricky to read and about 20 pixels wide.
Not actually. If you nest too far with prosilver, you actually lose visibility on the innermost contents. See attachment.
Attachments
xkcd-screenshot.png
xkcd-screenshot.png (8.41 KiB) Viewed 7143 times
A_Jelly_Doughnut

Post Reply