[RFC] Remove innermost quote

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.2/Rhea branch. Everything listed in this forum will be available in phpBB 3.2.
User avatar
galaxyAbstractor
Google Summer of Code Student
Posts: 17
Joined: Sun Sep 25, 2011 7:40 pm

[RFC] Remove innermost quote

Post by galaxyAbstractor » Thu Apr 05, 2012 2:48 pm

Scenario
A debate or long discussion is going on in a thread with multiple persons taking part, each quoting each others. At some point (rather fast in a debate) you will hit the "max nested quote" limit (default 3?) and you will not be able to post unless you remove a quote or two.

The problem
To be able to post, you have to remove either only the innermost quote, or all nested quotes leaving only the outermost quote intact (or just remove all quotes all together). The problem appears if there is a lot of BBCode or text in the quotes then it's extremely hard to remove the quotes by hand without messing up the syntax. This happens daily in a forum I am actively partaking in and the posts get messy. Even worse is if you have a custom BBCode installed like a spoiler tag and it's placed inside of one of the quotes and the structure is messed up, it can lead to the entire page below the post gets malformed or not showing at all.

Solution
Automatically remove the innermost quote if the quote limit is reached, alternatively only leaving the outermost quote (the post being quoted). It don't believe this would be against any usability issues as one of the quotes have to go either way, it just does it automatically, leaving less risk of user messing up.

Take this example structure as comparison:

Code: Select all

    [quote]
        Outermost quote
        [quote]
            2
            [quote]
                3
                [quote]
                    4 // Hit max nested quote limit
                [/quote]
            [/quote]
            Hey check this out

            [quote]
                Blah blah rest of some other post
            [/quote]
        [/quote]
        
       Or check this
       [quote]
            2
            [quote]
                3           
                [quote]
                    4 // Hit max nested quote limit
                [/quote]
            [/quote]
       [/quote]
    [/quote]
(indented because I confused myself, usually it isn't indented like this, also somewhat extreme example of showing how hard it can be to remove quotes the right way)

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Remove innermost quote

Post by callumacrae » Thu Apr 05, 2012 4:50 pm

Isn't this what "Maximum nesting depth for quotes" in Post settings does?

EDIT: Ah, sort of. It errors:
Image

I think that it would be better if it automatically removed the quote. At that depth, it wouldn't be read anyway and enough context is provided.
Made by developers, for developers!
My blog

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] Remove innermost quote

Post by jsebean » Mon Apr 09, 2012 6:06 pm

callumacrae wrote: I think that it would be better if it automatically removed the quote.
Isn't that what this RFC is about?

+1. Makes life easier for people who are new to BBCode, people who have to edit messages because quotes are messed up, and so it just makes life much easier for everyone, especially those new to BBCode.
-Jonah

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Remove innermost quote

Post by Oleg » Tue Apr 10, 2012 12:26 am

Is the bbcode engine rewrite meant to take care of this?

User avatar
naderman
Product Manager
Product Manager
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Remove innermost quote

Post by naderman » Tue Apr 10, 2012 1:22 pm

It would certainly make this very easy.

User avatar
galaxyAbstractor
Google Summer of Code Student
Posts: 17
Joined: Sun Sep 25, 2011 7:40 pm

Re: [RFC] Remove innermost quote

Post by galaxyAbstractor » Thu May 09, 2013 9:10 pm

I've been thinking about this one for a bit and I think I might have a way to solve it when I looked at the code. Just a question, should the user be alerted that a quote that was too deep was removed, or just remove it automatically without mentioning it to the user?

In my opinion, I would just have removed the quote automatically as the user most likely would have to remove it either way. Does that sound ok?

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Remove innermost quote

Post by Pony99CA » Fri May 10, 2013 1:30 am

callumacrae wrote:Isn't this what "Maximum nesting depth for quotes" in Post settings does?
That's what I would have guessed, too. If it just gives an error, we should remove it.
galaxyAbstractor wrote:I've been thinking about this one for a bit and I think I might have a way to solve it when I looked at the code. Just a question, should the user be alerted that a quote that was too deep was removed, or just remove it automatically without mentioning it to the user?

In my opinion, I would just have removed the quote automatically as the user most likely would have to remove it either way. Does that sound ok?
If the user Previews the post, display a message above the preview saying that the quote was removed; if he just Submits the post, remove it automatically.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.


User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Remove innermost quote

Post by bantu » Fri May 10, 2013 10:15 pm

This only works for full quotes using the quote button, otherwise we do want to tamper with user data because the quotes may contain external content which we should certainly not just throw away.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Remove innermost quote

Post by Pony99CA » Sat May 11, 2013 1:03 am

bantu wrote:This only works for full quotes using the quote button, otherwise we do want to tamper with user data because the quotes may contain external content which we should certainly not just throw away.
I'm not quite sure what you're getting at, but I think that you're saying that some people put copied material in QUOTE tags that aren't from posts.

While that's certainly true, if that material has been requoted, the original will still be there in the forum. I think that the only times that you'll run into problems are if somebody edited a nested quote or inserted new material there (which is against the spirit of quoting) or if somebody is quoting a deeply quoted post copied from another board (but you should link to the post anyway, at least in addition to quoting it).

The other alternative would be to have an "Unnest Quotes" button that would remove the inner quotes (and possibly automatically preview the post). If you had that, you could keep the error as it is today.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

Post Reply