[Template] overall_header_before

These requests for events in core phpBB have been merged into 3.1/Ascraeus and will be available with the next release.
Post Reply
hexplor
Registered User
Posts: 6
Joined: Wed Nov 27, 2013 10:20 am

[Template] overall_header_before

Post by hexplor » Mon Mar 24, 2014 1:31 pm

Identifier: overall_header_before
Prosilver Location (if applicable): Line 52, right after: <body id="phpbb" class="nojs section-{SCRIPT_NAME} {S_CONTENT_DIRECTION}">
Explanation: There's already present event for footer: overall_footer_before, so there should be corresponding one for overall_header.html as well. It would help to wrap the whole forum into container and add some design for template developers.

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: [Template] overall_header_before

Post by PayBas » Mon Mar 24, 2014 10:32 pm

Strongly agree. Also very handy for inserting toolbars that are "fixed" to the top of the page (outside of "wrap").

User avatar
Prosk8er
Registered User
Posts: 51
Joined: Sun Mar 11, 2007 1:19 am
Location: Rochester, Ny
Contact:

Re: [Template] overall_header_before

Post by Prosk8er » Mon Mar 24, 2014 11:52 pm

good ideal not sure why that one wasn't added yet if there's no ticket for it i'll submit one and a pull request on github for it :)

Ticket: http://tracker.phpbb.com/browse/PHPBB3-12301
Github Pull Request: https://github.com/phpbb/phpbb/pull/2181
formerly bprsk8r4272 Proud Kiss Portal user on phpBB 3.0.14 + 1.0.20 (build 311-020)
Image
Validated Extensions, Mods, and Styles My Mods: Smashable Christmas Lights 3.0.x Add a group to teampage 3.0.x

User avatar
Prosk8er
Registered User
Posts: 51
Joined: Sun Mar 11, 2007 1:19 am
Location: Rochester, Ny
Contact:

Re: [Template] overall_header_before

Post by Prosk8er » Wed Apr 16, 2014 1:49 am

just posting to say this was merged
formerly bprsk8r4272 Proud Kiss Portal user on phpBB 3.0.14 + 1.0.20 (build 311-020)
Image
Validated Extensions, Mods, and Styles My Mods: Smashable Christmas Lights 3.0.x Add a group to teampage 3.0.x


User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [Template] overall_header_before

Post by imkingdavid » Mon Apr 21, 2014 4:15 am

Alright, moving to merged forum.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply