Dropping the tests/functional directory

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Dropping the tests/functional directory

Post by bantu » Sun Apr 14, 2013 6:33 pm

I am not sure whether there was a good reason for having functional tests separate in the tests/functional directory or whether it was just for technical reasons. PHPUnit's grouping annotation (@group functional) seems to be sufficient and would allow tests to be grouped by topic/feature instead of having functional tests separate. Therefore I am proposing dropping the tests/functional directory and moving existing tests into the existing structure.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Dropping the tests/functional directory

Post by imkingdavid » Sun Apr 14, 2013 7:14 pm

I like having the separation so that I know which ones are functional and which aren't without having to look inside the file. But I suppose I would be okay with this if you guys decide to do this.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: Dropping the tests/functional directory

Post by MichaelC » Sun Apr 14, 2013 10:23 pm

imkingdavid wrote:I like having the separation so that I know which ones are functional and which aren't without having to look inside the file. But I suppose I would be okay with this if you guys decide to do this.
+1 to that.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Dropping the tests/functional directory

Post by bantu » Sun Apr 14, 2013 10:38 pm

Well, they are in different test suites, so from that perspective I guess it makes sense. On the other hand, you have to visit two places when it comes to the question whether something has test coverage.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Dropping the tests/functional directory

Post by imkingdavid » Mon Apr 15, 2013 3:24 pm

Can we add "_functional" or prefix with "functional_" to all functional test files? If so, that would eliminate the need for a separate folder.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Dropping the tests/functional directory

Post by Oleg » Wed Apr 17, 2013 3:08 am

I am not seeing how functional tests (which cover multiple units) would fit into unit test directory structure.

I cannot recall a single project that mixed unit and functional tests like that.

I wrote test suites that folded unit tests into integration tests, but this is opposite direction of what is being proposed here.

Let's see the patch doing just the renames?

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: Dropping the tests/functional directory

Post by bantu » Wed Apr 17, 2013 3:15 am

Oleg wrote:Let's see the patch doing just the renames?
I haven't done any work for this yet, basically just wanted to know whether there was a good reason for having them separate.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: Dropping the tests/functional directory

Post by Oleg » Wed Apr 17, 2013 3:24 am

Oleg wrote:I am not seeing how functional tests (which cover multiple units) would fit into unit test directory structure.
would be my concern.

What is an example situation where it is unclear where a test for something is?

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: Dropping the tests/functional directory

Post by imkingdavid » Wed Apr 17, 2013 2:34 pm

I don't think he's concerned that it's unclear whether or not a test exists for a given feature, I think he's more concerned with having to check multiple places to find it out.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: Dropping the tests/functional directory

Post by MichaelC » Wed Apr 17, 2013 3:50 pm

Do we not have anything that checks code coverage of phpBB?
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Post Reply