[RFC|Rejected] <base>

[MichaelC]

So it brakes BC?

In that case I think I'm -1

[nickvergessen]

Will it cause problems if append_sid calls are not changed?

It will for calls where $phpbb_root_path is not ./
phpbb_root_path should be removed from all append_sid() calls

if that is the case its a no go!
We wont change all calls to append_sid and require that from everyone out there to do with their custom codes.

[imkingdavid]

We can add something to append_sid() to remove the root path from URLs passed into it. I do something similar to mutate the paths sent to append_sid() in my Controller PR; otherwise, controllers do not display properly with CSS and javascript because paths are relative to the URL in the address bar, rather than the script actually being run, which is where the root path is defined.

If we change append_sid() to remove the root path from anything provided to it and then for future code just omit the root path altogether, then implementing a <base> tag would not be an issue, afaik.

[Dragosvr92]

Maybe just wait and add it for phpbb 4.0 ?
Then the peoples codes/mods will become obsolete anyways.
They will have to overwrite their entire forum software and save just the db and attached board files.

[bantu]

This probably only works for (X)HTML output, so is probably not a good idea. We already have other output formats such as ATOM and will probably get more in the future (e.g. JSON).

[Marc]

I'd say at least -1 for phpBB 3.1.

[nickvergessen]

Closing as rejected as per above comments