[RFC|Rejected] <base>

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] <base>

Post by MichaelC »

So it brakes BC?

In that case I think I'm -1
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] <base>

Post by nickvergessen »

Arty wrote:
EXreaction wrote:Will it cause problems if append_sid calls are not changed?
It will for calls where $phpbb_root_path is not ./
phpbb_root_path should be removed from all append_sid() calls
if that is the case its a no go!
We wont change all calls to append_sid and require that from everyone out there to do with their custom codes.
Member of the Development-TeamNo Support via PM

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] <base>

Post by imkingdavid »

We can add something to append_sid() to remove the root path from URLs passed into it. I do something similar to mutate the paths sent to append_sid() in my Controller PR; otherwise, controllers do not display properly with CSS and javascript because paths are relative to the URL in the address bar, rather than the script actually being run, which is where the root path is defined.

If we change append_sid() to remove the root path from anything provided to it and then for future code just omit the root path altogether, then implementing a <base> tag would not be an issue, afaik.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Dragosvr92
Registered User
Posts: 624
Joined: Tue May 31, 2011 12:08 pm
Location: Romania
Contact:

Re: [RFC] <base>

Post by Dragosvr92 »

Maybe just wait and add it for phpbb 4.0 ?
Then the peoples codes/mods will become obsolete anyways.
They will have to overwrite their entire forum software and save just the db and attached board files.
Last edited by Dragosvr92 on Tue Nov 06, 2012 1:40 am, edited 1 time in total.
Previous user: TheKiller
Avatar on Memberlist 1.0.3

User avatar
bantu
3.0 Release Manager
3.0 Release Manager
Posts: 557
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] <base>

Post by bantu »

This probably only works for (X)HTML output, so is probably not a good idea. We already have other output formats such as ATOM and will probably get more in the future (e.g. JSON).

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 155
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] <base>

Post by Marc »

I'd say at least -1 for phpBB 3.1.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] <base>

Post by nickvergessen »

Closing as rejected as per above comments
Member of the Development-TeamNo Support via PM

Post Reply