[RFC|Rejected] Revert all of ajax in 3.1

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
User avatar
tbackoff
Registered User
Posts: 180
Joined: Sat Jun 12, 2010 3:25 am

Re: [RFC] Revert all of ajax in 3.1

Post by tbackoff »

Unknown Bliss wrote:What I believe your referring to (quick mod, if not disregard this) is not still broken
I was referring to "Mark forums/topics read". Has this been fixed? Also, my previous question/statement still stands:
t_backoff wrote:if we are going to ajax, it needs to be throughout the entire core, not bits and parts. For example, why are we using trigger_error in some parts, but ajax in others?
[snip]
Choose one, the other, or none at all.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Revert all of ajax in 3.1

Post by MichaelC »

t_backoff wrote:
Unknown Bliss wrote:What I believe your referring to (quick mod, if not disregard this) is not still broken
I was referring to "Mark forums/topics read". Has this been fixed? Also, my previous question/statement still stands:
t_backoff wrote:if we are going to ajax, it needs to be throughout the entire core, not bits and parts. For example, why are we using trigger_error in some parts, but ajax in others?
[snip]
Choose one, the other, or none at all.
It works, but it doesn't update the icons, but yes, that still needs fixing (I think)

The whole point is AJAX'ing it bit by bit, not all at the same time. That's what caused all the problems in the first place.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Revert all of ajax in 3.1

Post by imkingdavid »

t_backoff wrote:
t_backoff wrote:if we are going to ajax, it needs to be throughout the entire core, not bits and parts. For example, why are we using trigger_error in some parts, but ajax in others?
[snip]
Choose one, the other, or none at all.
...because sometimes you need a trigger_error() and other places make more sense to display a modal box or a flash message or something. We aren't trying to turn this into ajaxBB. We are just trying to implement AJAX technology into places in which it makes sense.

It is better to get the basic AJAX framework merged and then work on features bit by bit, testing and reviewing each one separately, than to try and fit everything into one huge, unreadable PR that will inevitably be merged without proper review. :? :oops:

Think of it like making a new software. If you try to implement everything at once, you get very sketchy, disorganized and orphaned (i.e. unused but retained because you forgot to remove it) code. If you focus your efforts on one feature at a time and give each one the attention it deserves, you get a much cleaner and more maintainable code base.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Danielx64
Registered User
Posts: 304
Joined: Mon Feb 08, 2010 3:42 am

Re: [RFC] Revert all of ajax in 3.1

Post by Danielx64 »

imkingdavid wrote:If you want to revert this because it lacks the proper documentation of what it does, then you might as well just scrap the majority of the phpBB codebase, which also lacks proper documentation, and rewrite it from scratch (that's where 4.0 comes in).
^ This

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by naderman »

That's really not a reason to add any new code lacking documentation.

User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by Erik Frèrejean »

naderman wrote:That's really not a reason to add any new code lacking documentation.
Though neither a reason to remove already added code, especially as it is hard to expect that anyone will jump in to redo this based upon the way this iteration was handled.
Available on .com
Support Toolkit developer

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Revert all of ajax in 3.1

Post by imkingdavid »

naderman wrote:That's really not a reason to add any new code lacking documentation.
No one ever suggested, as far as I can tell, adding any further code without documentation. All that has been suggested so far (by me, at least) is to keep what we have and work on documenting it, rather than scrapping it and starting over. A bunch have time has already been spent on it, it would be a waste to toss that out just because the code is currently undocumented. Instead, let's just document what we have.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Revert all of ajax in 3.1

Post by igorw »

I was mostly in charge of finishing up the pull request and the docs in the wiki.

There have been quite a lot of different issues discussed here. But I feel like some things are missing from the discussion. Before I comment on what I think we should or should not do, I'd like to hear some answers to these questions:
  • Where exactly (apart from bugs) do you see shortcomings in the current code, and how would you improve it?
  • Where exactly do you see shortcomings in the current documentation, and how would you improve it?

User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by Erik Frèrejean »

A better solution rather then just nuking this would be to fix up the issues for 3.1, and create a new RFC which is aimed to improve/rewrite parts of the current codebase for 3.2. Software can evolve over time and I believe that this is a case that can evolve quite a bit.
Available on .com
Support Toolkit developer

User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by Erik Frèrejean »

t_backoff wrote:not to mention it's still broken.
Are there tickets for those "still" broken? If there are then those issues will be resolved, if not it is hard to expect them to be solved at any point ;)
Available on .com
Support Toolkit developer

Post Reply