[RFC|Rejected] Revert all of ajax in 3.1

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by Oleg » Thu Jun 28, 2012 2:39 am

igorw wrote:the docs in the wiki.
These are quite good, I must not have read the last iteration of them. They seem to not cover everything that was originally pull requested, but the operations that they do cover and what currently actually works seems to be more or less the same set, which happens to be sufficiently well defined in my opinion.

Therefore a complete revert is unnecessary.

To answer the other questions, it was not any one thing but a combination of incomprehensible code written to no spec and with no documentation (which was my opinion at the time, proven incorrect). As there in fact is a reasonable spec and documentation the code can be fixed.

As to why revert ajax but not the entire phpbb codebase, the value ajax provides as currently implemented (very little) was outweighed by the pain of having to constantly deal with it when writing new javascript code (ongoing).

I filed http://tracker.phpbb.com/browse/PHPBB3-10955 to start on improving the code. This was one of the points I raised in the original PR.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1830
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by DavidIQ » Thu Jun 28, 2012 2:58 am

Do we want tickets for every nuance about Ajax or have something that encompasses all? I keep approving posts on here, for instance, and clicking on the Yes button works but the way the "action completed" modal works seems to be a bit out of place. Clicking on "Return to post" refreshes the whole page when the modal should just close and take me to the post.
Image

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by Oleg » Thu Jun 28, 2012 6:08 am

Separate issues should get separate tickets, same as always.

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by callumacrae » Thu Jun 28, 2012 6:55 am

Oleg wrote:I filed http://tracker.phpbb.com/browse/PHPBB3-10955 to start on improving the code. This was one of the points I raised in the original PR.
And it was one of the points that was addressed.

Code: Select all

phpbb.ajaxify = function(options) {
An I missing something here?
Made by developers, for developers!
My blog

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Revert all of ajax in 3.1

Post by MichaelC » Thu Jun 28, 2012 2:54 pm

DavidIQ wrote:Do we want tickets for every nuance about Ajax or have something that encompasses all? I keep approving posts on here, for instance, and clicking on the Yes button works but the way the "action completed" modal works seems to be a bit out of place. Clicking on "Return to post" refreshes the whole page when the modal should just close and take me to the post.
Would be done in viewtopic.php?f=108&t=43067 (turned into a flash message).
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] Revert all of ajax in 3.1

Post by naderman » Wed Jul 04, 2012 2:09 am

Alright so since I think we all agree a revert is unecessary, and problems will be fixed with the respective tickets and new RFCs I'll move this RFC to the rejected forum.

Post Reply