[RFC|Rejected] Imageset Improvements

These RFCs were either rejected or have been replaced by an alternative proposal. They will not be included in phpBB.
Post Reply
Sam
Registered User
Posts: 31
Joined: Fri Jan 23, 2009 10:24 pm

[RFC|Rejected] Imageset Improvements

Post by Sam » Thu May 20, 2010 9:38 am

I was creating a MOD recently, and it took me the better part of 2 hours trying to figure out how to add a button next to the edit button. The solution? an edit in includes/acp/acp_style.php. Does this not defeat the purpose of having the configuration file? Sure it allows other styles to specify different filenames, but the imageset is locked in unless you edit the acp_styles.php file. My suggestion is to make it completely dependent on the config file allow for easier and seamless extending upon the imageset.

igorw
Registered User
Posts: 500
Joined: Thu Jan 04, 2007 11:47 pm

Re: [RFC] Imageset Improvements

Post by igorw » Thu May 20, 2010 10:01 am

Another thing is CSS. You need to add CSS to add images. There should be a mechanism of auto-including all CSS files of a certain folder, such as styles/<stylename>/theme/mods/*.css.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Imageset Improvements

Post by nickvergessen » Thu May 20, 2010 2:06 pm

You also need to change the includes/acp/acp_language.php if you want to do that correctly.
Member of the Development-TeamNo Support via PM

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC|Rejected] Imageset Improvements

Post by naderman » Thu May 31, 2012 2:32 am

No longer relevant as Imagesets have been removed from 3.1

Post Reply