[PHP]core.messenger_phpbb_mail

Request hook events and what data needs to be sent for the new hook system.
Post Reply
bobby124
Registered User
Posts: 19
Joined: Mon Mar 10, 2014 9:49 pm

[PHP]core.messenger_phpbb_mail

Post by bobby124 » Tue Nov 25, 2014 8:01 pm

Identifer:core.messenger_phpbb_mail
Location:/includes/functions_messenger
Parameters:

Code: Select all

$result = $config['email_function_name']($to, mail_encode($subject, ''), wordwrap(utf8_wordwrap($msg), 997, "\n", true), $headers);
Explanation: There is a probleme with POSTFIX and PHPBB
Yahoo reject email because of header parameters. To resolve this problem i need to change Parameter with:

Code: Select all

$result = $config['email_function_name']($to, mail_encode($subject, ''), wordwrap(utf8_wordwrap($msg), 997, "\n", true), $headers, "-f" . $config['board_email']);

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [PHP]core.messenger_phpbb_mail

Post by DavidIQ » Tue Nov 25, 2014 8:40 pm

Wouldn't this just be a bug?
Image

bobby124
Registered User
Posts: 19
Joined: Mon Mar 10, 2014 9:49 pm

Re: [PHP]core.messenger_phpbb_mail

Post by bobby124 » Tue Nov 25, 2014 9:28 pm

You ask to me?
I don't know it's a issue with Postfix mail service.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [PHP]core.messenger_phpbb_mail

Post by DavidIQ » Tue Nov 25, 2014 9:41 pm

Right but what I'm saying is that if all this is doing is adding a parameter to the header that is fixing an issue then perhaps it should be fixed in the phpBB core especially if it doesn't affect email in general. Events can add overhead so adding one for something like this seems unnecessary.
Image

bobby124
Registered User
Posts: 19
Joined: Mon Mar 10, 2014 9:49 pm

Re: [PHP]core.messenger_phpbb_mail

Post by bobby124 » Tue Nov 25, 2014 10:05 pm

Ok thanks, but how to add an overhead like this in a event?

Code: Select all

"-f" . $config['board_email']
Because like a member point out there is not event in the file /includes/functions_messenger.php in this topic https://www.phpbb.com/community/viewtop ... &t=2271841

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [PHP]core.messenger_phpbb_mail

Post by DavidIQ » Wed Nov 26, 2014 12:54 am

I don't think you're understanding what I'm saying. It appears you're requesting an event when in reality the point of the event might possibly be to fix a bug, so instead of an event perhaps this is something that needs to be fixed in the core.
Image

bobby124
Registered User
Posts: 19
Joined: Mon Mar 10, 2014 9:49 pm

Re: [PHP]core.messenger_phpbb_mail

Post by bobby124 » Wed Nov 26, 2014 7:52 am

ok but who will ask for this fix?

Post Reply