[RFC|Implemented] core.append_sid

These requests for events in core phpBB have been merged into 3.1/Ascraeus and will be available with the next release.
Post Reply
User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

[RFC|Implemented] core.append_sid

Post by Erik Frèrejean » Thu May 31, 2012 8:44 pm

Name: core.append_sid
Rationale: There currently is an hook in append_sid but this hook only allows an author to completely overwrite the function. This however poses a limitation when an author only wants to inject/change the passed variables, in that case he'll has to copy the whole function in his hook and make the change. It makes sense to replace the old hook with a new event that acts the same way as the core.page_header_override event. Thus keeping the old behavior where an author can override the whole function by setting a $append_sid_override variable or otherwise simply give the option to edit the variables and continue executing the function itself.
Placement: /includes/functions.php, at the top of append_sid replacing the current hook
Input arguments: $url, $params, $is_amp, $session_id, $append_sid_override
Last edited by imkingdavid on Sat Sep 01, 2012 8:09 pm, edited 2 times in total.
Reason: typo
Available on .com
Support Toolkit developer

User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany
Contact:

Re: [RFC] core.append_sid

Post by naderman » Tue Jun 05, 2012 11:08 pm

+1

User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

Re: [RFC] core.append_sid

Post by Erik Frèrejean » Wed Jun 06, 2012 11:42 am

Corrected the RFC to list the correct variable names.
Available on .com
Support Toolkit developer

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] core.append_sid

Post by MichaelC » Wed Jun 06, 2012 12:04 pm

Ok, this won't go in the current PR as its getting too big but I'll do this once its merged (unless erik beats me too it)
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] core.append_sid

Post by imkingdavid » Mon Aug 20, 2012 3:58 pm

I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC|Implemented] core.append_sid

Post by imkingdavid » Sat Sep 01, 2012 8:09 pm

This has been merged.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply