[RFC|Implemented] get_username_string hook

[Sam]

Name: hook_username_string
Rationale: This hook will allow someone to overwrite the get_username_string function
Placement: includes/functions_display.php
Input arguments: $mode, $user_id, $username, $username_colour, $guest_username, $custom_profile_url (get_username_string clone)
Output format: string
Output semantics: Returns what get_username_string returns.
Infrastructure: This would allow people to generate things such as username prefixes, pretty viewprofile urls, different viewprofile urls, and other custom effects on the username as it is displayed.

[3Di]

I would add also the user_ip thinghy here.

[Sam]

The hook would essentially act as a full replacement for the get_username_string() function. The User IP is not used for it.

[3Di]

The hook would essentially act as a full replacement for the get_username_string() function. The User IP is not used for it.

It does not harm to have it, I can use it.

[3Di]

At the end of all, anyway I mean, I could use that proposed hook ( that's a good idea IMHO ) just forking it or whatever and blah blah, adding whatever I like (hopefully). I do not see where the problem is .. so, adding the IP?

[imkingdavid]

I added the event: core.alter_username_string

This will let you take the output generated by get_username_string and modify as needed, or even completely overwrite that.

This has not yet been added to the core. To see the changes made, you can view the following: https://github.com/imkingdavid/phpbb3/c ... 576570acaa

I would add also the user_ip thinghy here.

User IP is not provided to the get_username_string function, so it is not available to the event.

[nickvergessen]

should be "modify" instead of "alter" as we used that several times

[imkingdavid]

This has been merged.