[RFC] Limit the subforums in legend to 1 level.

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

[RFC] Limit the subforums in legend to 1 level.

Post by PayBas » Wed May 07, 2014 10:54 am

You might think that this can be effectively controlled by using the "List subforums in legend" and "List subforum in parent-forum’s legend", but those have global effects. For instance: you might want to show the sub-forums in the legend when browsing inside the category parent forum, but not on the index.

In it's current form, it's a bit of an all-or-nothing approach, which can become very cluttered and confusing.
Untitled-1.png
Untitled-1.png (30.49 KiB) Viewed 4912 times
If you want to try it out yourself, open includes/functions_display.php

Find: $subforums[$parent_id][$forum_id]['display'] = ($row['display_on_index']) ? true : false;

Replace with: $subforums[$parent_id][$forum_id]['display'] = ($row['display_on_index'] && $parent_id == $row['parent_id']) ? true : false;

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: [RFC] Limit the subforums in legend to 1 level.

Post by Louis7777 » Wed May 07, 2014 11:36 am

What is the practice that others have followed? IPB, XenForo, vBulletin, SMF, MyBB etc. Some people may consider it a nice feature to display all the subforums in the legend, so if other vendors offer it, then we shouldn't take it away.

Is this RFC about adding a new option to control the display or to always have the legend display only level 1 subforums?

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: [RFC] Limit the subforums in legend to 1 level.

Post by PayBas » Wed May 07, 2014 11:52 am

They either use a drop-down menu (which I always use myself in my styles too), or they only display 1 level.

XenForo: dropdown: http://xenforo.com/community/
IPB: single level: http://community.invisionpower.com/
SMF: single level: http://www.simplemachines.org/community/

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Limit the subforums in legend to 1 level.

Post by brunoais » Wed May 07, 2014 2:52 pm

I like the multi-level display of sub-forums. And, as you propose, I also think it should be an option forum-by-forum instead of global.
(shouldn't this be in the ideas section of the main phpbb website?)

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: [RFC] Limit the subforums in legend to 1 level.

Post by PayBas » Wed May 07, 2014 4:04 pm

brunoais wrote:I like the multi-level display of sub-forums. And, as you propose, I also think it should be an option forum-by-forum instead of global.
(shouldn't this be in the ideas section of the main phpbb website?)
It's a request for comment/change, so I thought it would be fine in the RFC section ;).

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: [RFC] Limit the subforums in legend to 1 level.

Post by Louis7777 » Wed May 07, 2014 6:16 pm

I personally don't like those dropwdowns at all. And the one at XenForo displays the forum title in the dropdown... why would they do that when the title is already on the left... it's so ugly...

Although I'm mostly fine with displaying only level 1, I believe there would be forum cases where I might like to display all of them.

How about adding another option to control the display per forum?

User avatar
Master_Cylinder
Registered User
Posts: 361
Joined: Wed Jul 31, 2013 9:54 pm

Re: [RFC] Limit the subforums in legend to 1 level.

Post by Master_Cylinder » Wed May 07, 2014 7:14 pm

I like it as is but if it's an ACP *option* then it won't matter.
These kids today...
Buy them books, send them to school and what do they do?

They eat the paste. :lol:

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Limit the subforums in legend to 1 level.

Post by Pony99CA » Thu May 08, 2014 2:19 am

Why not make it a UCP option and let the user decide what level of nesting he wants to see? The admin should only control important things; the user should control how he views things.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
Master_Cylinder
Registered User
Posts: 361
Joined: Wed Jul 31, 2013 9:54 pm

Re: [RFC] Limit the subforums in legend to 1 level.

Post by Master_Cylinder » Thu May 08, 2014 7:25 am

The user should only be allowed to decide what the admin wants the users to decide.
These kids today...
Buy them books, send them to school and what do they do?

They eat the paste. :lol:

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Limit the subforums in legend to 1 level.

Post by brunoais » Thu May 08, 2014 12:17 pm

I'm ok with UCP option too.

Post Reply