Leave some space below titles?

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Leave some space below titles?

Post by Louis7777 » Mon Apr 14, 2014 11:50 pm

I think the whitespace below the titles should be as much as that between the title and the header. What do you think?

Viewtopic:
viewtopic.png
viewtopic.png (16.76 KiB) Viewed 4494 times
Viewforum:
viewforum.png
viewforum.png (17.44 KiB) Viewed 4494 times
Posting:
posting.png
posting.png (12.23 KiB) Viewed 4494 times

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: Leave some space below titles?

Post by DavidIQ » Tue Apr 15, 2014 3:20 am

That would mean more scrolling. Could argue that the white space above it should be eliminated...

I think it's fine as it is. The idea is that the title is part of the content that follows it.
Image

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Leave some space below titles?

Post by EXreaction » Tue Apr 15, 2014 5:10 am

We can already see what the whitespace is currently, how about what it would look like with the amount you're suggesting? ;)

User avatar
PayBas
Registered User
Posts: 305
Joined: Tue Jul 29, 2008 6:08 pm
Contact:

Re: Leave some space below titles?

Post by PayBas » Tue Apr 15, 2014 7:39 am

I think it would be a much better idea to include a CSS class into the <h2> elements.

Currently, they are all just <h2> without any class. You have to style them using weird code like:

body.section-viewforum h2 { margin-top: 1.1em; }
body.section-viewtopic h2 { color: #555 }

By including classes into the title like: <h2 class="topic-heading"> (.topic-title is taken already I think), you can easily style them any way you want.

User avatar
Louis7777
Registered User
Posts: 378
Joined: Fri Apr 04, 2014 12:32 am

Re: Leave some space below titles?

Post by Louis7777 » Tue Apr 15, 2014 11:04 am

In other pages the titles stand out:
ucp.png
ucp.png (10.48 KiB) Viewed 4437 times
memberlist.png
memberlist.png (10.17 KiB) Viewed 4437 times
EXreaction wrote:We can already see what the whitespace is currently, how about what it would look like with the amount you're suggesting? ;)
Not much amount, as much as a single line break would be (<br />):
viewtopic.png
viewtopic.png (51.23 KiB) Viewed 4436 times
posting.png
posting.png (44.38 KiB) Viewed 4436 times
viewforum.png
viewforum.png (46.91 KiB) Viewed 4436 times
PayBas wrote:I think it would be a much better idea to include a CSS class into the <h2> elements.

Currently, they are all just <h2> without any class. You have to style them using weird code like:

body.section-viewforum h2 { margin-top: 1.1em; }
body.section-viewtopic h2 { color: #555 }

By including classes into the title like: <h2 class="topic-heading"> (.topic-title is taken already I think), you can easily style them any way you want.
Yeah, that would be good if not better. :) The top margin should be left as it is - better have a margin-bottom and then anyone can change that amount the way he wants.

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: Leave some space below titles?

Post by EXreaction » Tue Apr 15, 2014 6:35 pm

I think that looks better than it is now.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: Leave some space below titles?

Post by Pony99CA » Thu Apr 17, 2014 1:43 am

I don't think that the current way looks bad. The suggested way looks worse for the Posting example (too much space below the title).

I do agree with using CSS classes on the Header elements.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: Leave some space below titles?

Post by keith10456 » Thu Apr 17, 2014 2:44 am

+1 for adding classes to the h2 elements.

User avatar
Mess
Registered User
Posts: 197
Joined: Wed Jun 13, 2012 10:14 am

Re: Leave some space below titles?

Post by Mess » Thu Apr 17, 2014 7:18 am

-1 for adding the extra space. I feel the topoc title has a better connection with topic currently.

User avatar
Jessica.
Registered User
Posts: 144
Joined: Wed Feb 09, 2011 8:17 pm
Location: Pennsylvania, USA
Contact:

Re: Leave some space below titles?

Post by Jessica. » Thu Apr 17, 2014 9:05 pm

Looks fine now. No need for more space, in my opinion.

Post Reply