[RFC] Option for RSS icons in Prosilver

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
aleha
Registered User
Posts: 143
Joined: Tue Mar 26, 2013 2:19 am

[RFC] Option for RSS icons in Prosilver

Post by aleha »

I would like to know if you find it a good idea to have an option for showing RSS icons in prosilver, per forum/category etc.

An example can be found in the Supernova style, here.

I am talking for an option instead of this to be always enabled but that's debatable.

User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC] Option for RSS icons in Prosilver

Post by nextgen »

What you can do is to remove the comments of these files for show rss in the forum.

forumlist_body.html

Code: Select all

						<!-- IF S_ENABLE_FEEDS and forumrow.S_FEED_ENABLED --><!-- <a class="feed-icon-forum" title="{L_FEED} - {forumrow.FORUM_NAME}" href="{U_FEED}?f={forumrow.FORUM_ID}"><img src="{T_THEME_PATH}/images/feed.gif" alt="{L_FEED} - {forumrow.FORUM_NAME}" /></a> --><!-- ENDIF -->
with this:

Code: Select all

						<!-- IF S_ENABLE_FEEDS and forumrow.S_FEED_ENABLED --><a class="feed-icon-forum" title="{L_FEED} - {forumrow.FORUM_NAME}" href="{U_FEED}?f={forumrow.FORUM_ID}"><img src="{T_THEME_PATH}/images/feed.gif" alt="{L_FEED} - {forumrow.FORUM_NAME}" /></a><!-- ENDIF -->
Not is if that you mean :roll:
*Imagine a signature super spectacular.*

aleha
Registered User
Posts: 143
Joined: Tue Mar 26, 2013 2:19 am

Re: [RFC] Option for RSS icons in Prosilver

Post by aleha »

Yes, that is what I have seen in other styles. The option that you give exists in prosilver both in 3.0.12 and 3.1-a1.
Am I missing an option for this in UCP or ACP else why is this in a comment block?

edit: Is there thought for an option for an icon for the forum feed? Like a big icon under the search bar or smth like that.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1834
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Option for RSS icons in Prosilver

Post by DavidIQ »

There is no option, presumably because it is not generally accepted to have RSS feed icons on pages and instead the browser RSS integration should be used to detect and subscribe to these feeds. Another reason might be possible server load issues. Not sure that there are a lot of people desiring to enable this either.

To me RSS icons on a forum would look unsightly/ugly in general but that's just my opinion.
Image

keith10456
Registered User
Posts: 523
Joined: Sat Apr 22, 2006 10:29 pm
Contact:

Re: [RFC] Option for RSS icons in Prosilver

Post by keith10456 »

DavidIQ wrote:There is no option, presumably because it is not generally accepted to have RSS feed icons on pages and instead the browser RSS integration should be used to detect and subscribe to these feeds. Another reason might be possible server load issues. Not sure that there are a lot of people desiring to enable this either.

To me RSS icons on a forum would look unsightly/ugly in general but that's just my opinion.
Agreed. One icon in the header - maybe (if at all). Not a bunch of them for each board. This would be better as an extension.

User avatar
wintstar
Registered User
Posts: 108
Joined: Sun Dec 02, 2012 1:38 pm
Location: Lanngöns/Hessen Germany
Contact:

Re: [RFC] Option for RSS icons in Prosilver

Post by wintstar »

aleha wrote:I would like to know if you find it a good idea to have an option for showing RSS icons in prosilver, per forum/category etc.

An example can be found in the Supernova style, here.

I am talking for an option instead of this to be always enabled but that's debatable.
-1
Greeting Stephan :-)

Quote: "To achieve the possible, the impossible has to be tried again and again" (Hermann Hesse (1877-1962)).
A look into the future phpBB 3.1.0 - Board, current Builds
A look into the future phpBB 3.1.0 - Board-Plus, Extensions in the test

aleha
Registered User
Posts: 143
Joined: Tue Mar 26, 2013 2:19 am

Re: [RFC] Option for RSS icons in Prosilver

Post by aleha »

DavidIQ wrote:There is no option, presumably because it is not generally accepted to have RSS feed icons on pages and instead the browser RSS integration should be used to detect and subscribe to these feeds. Another reason might be possible server load issues. Not sure that there are a lot of people desiring to enable this either.

To me RSS icons on a forum would look unsightly/ugly in general but that's just my opinion.
I can't say that I disagree with you so if there is no use for this code then it's dead code.
Maybe there could be an rss icon in the footer.

Post Reply