[RFC] Board offline

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
wintstar
Registered User
Posts: 108
Joined: Sun Dec 02, 2012 1:38 pm
Location: Lanngöns/Hessen Germany
Contact:

[RFC] Board offline

Post by wintstar »

First I want to say that I am not a great master in php. What is offline board? Board Offline is an idea for phpBB 3.1. More information can be found here in this topic https://www.phpbb.com/ideas/idea.php?id=127. Now I have made ​​the changes in this build # 1108. Since I'm not so manage with github I have published this here https://github.com/phpbb/phpbb/pull/1791. This function would enrich 3.1. :)
Ticket http://tracker.phpbb.com/browse/PHPBB3-11934
Last edited by wintstar on Thu Oct 17, 2013 4:50 pm, edited 1 time in total.
Greeting Stephan :-)

Quote: "To achieve the possible, the impossible has to be tried again and again" (Hermann Hesse (1877-1962)).
A look into the future phpBB 3.1.0 - Board, current Builds
A look into the future phpBB 3.1.0 - Board-Plus, Extensions in the test

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1845
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Board offline

Post by DavidIQ »

Any new RFCs will not make it into 3.1 especially now that it has entered the Alpha stage. They would be for 3.2. Same will go for the other RFCs that were recently created in this forum. Sounds like a good feature though.
Image

User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] Board offline

Post by EXreaction »

You must:

1. Have a ticket open for this issue in the tracker
2. Properly format commit messages: https://wiki.phpbb.com/Git#Commit_Messages
3. Create a pull request against phpbb/phpbb develop

You should also use branches rather than a new fork, it will make things easier for you. https://wiki.phpbb.com/Git#Branch_Names

User avatar
Kamahl19
Registered User
Posts: 161
Joined: Thu Dec 27, 2007 10:31 am

Re: [RFC] Board offline

Post by Kamahl19 »

I thought alpha stage means there are not all features implemented yet. So I dont see a problem in adding this to 3.1, if it is well written (I dont know I did not check). Or is it against some phpbb release policy? :)

User avatar
wintstar
Registered User
Posts: 108
Joined: Sun Dec 02, 2012 1:38 pm
Location: Lanngöns/Hessen Germany
Contact:

Re: [RFC] Board offline

Post by wintstar »

I have created ticket, please look here http://tracker.phpbb.com/browse/PHPBB3-11934. I still fight with github :oops:
Greeting Stephan :-)

Quote: "To achieve the possible, the impossible has to be tried again and again" (Hermann Hesse (1877-1962)).
A look into the future phpBB 3.1.0 - Board, current Builds
A look into the future phpBB 3.1.0 - Board-Plus, Extensions in the test

User avatar
wintstar
Registered User
Posts: 108
Joined: Sun Dec 02, 2012 1:38 pm
Location: Lanngöns/Hessen Germany
Contact:

Re: [RFC] Board offline

Post by wintstar »

I do not get it down. 'm Always cloned develop-olympus instead develop. https://github.com/wintstar/phpbb :?
Greeting Stephan :-)

Quote: "To achieve the possible, the impossible has to be tried again and again" (Hermann Hesse (1877-1962)).
A look into the future phpBB 3.1.0 - Board, current Builds
A look into the future phpBB 3.1.0 - Board-Plus, Extensions in the test

User avatar
Pico88
Registered User
Posts: 73
Joined: Tue Apr 12, 2011 2:32 pm

Re: [RFC] Board offline

Post by Pico88 »

Are you using GitHub app? Have you tired to change the branch? ;-)

User avatar
wintstar
Registered User
Posts: 108
Joined: Sun Dec 02, 2012 1:38 pm
Location: Lanngöns/Hessen Germany
Contact:

Re: [RFC] Board offline

Post by wintstar »

Yes i have change the branch to develop. I use github for windows. With console and command prompt I do not understand.
Greeting Stephan :-)

Quote: "To achieve the possible, the impossible has to be tried again and again" (Hermann Hesse (1877-1962)).
A look into the future phpBB 3.1.0 - Board, current Builds
A look into the future phpBB 3.1.0 - Board-Plus, Extensions in the test

User avatar
wintstar
Registered User
Posts: 108
Joined: Sun Dec 02, 2012 1:38 pm
Location: Lanngöns/Hessen Germany
Contact:

Re: [RFC] Board offline

Post by wintstar »

Greeting Stephan :-)

Quote: "To achieve the possible, the impossible has to be tried again and again" (Hermann Hesse (1877-1962)).
A look into the future phpBB 3.1.0 - Board, current Builds
A look into the future phpBB 3.1.0 - Board-Plus, Extensions in the test

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1845
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Board offline

Post by DavidIQ »

Kamahl19 wrote:I thought alpha stage means there are not all features implemented yet. So I dont see a problem in adding this to 3.1, if it is well written (I dont know I did not check). Or is it against some phpbb release policy? :)
If the development team wants to go against their own policies or mandates then that's fine too I guess. ;) Adding new features to any release, be it alpha or beta, adds instability to an already presumed unstable product.
Image

Post Reply