[RFC] user signature modifications for posts

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
EXreaction
Registered User
Posts: 1555
Joined: Sat Sep 10, 2005 2:15 am

Re: [RFC] user signature modifications for posts

Post by EXreaction » Thu Dec 27, 2012 5:17 am

Actually, I think that would be better off as part of the core rather than as an extension if done at all. I do not think that the audience for installing the extension where users would want it most are aligned with administrator's preferences (if administrators want to allow large signatures, I do not think it likely that they would install (or look for) an extension allowing users to disable it on a user by user basis).

On the other hand, it does not seem like it is something we should add a bunch of code for and another query for, so perhaps using a bit of javascript and client side storage would be the best idea for a user by user basis.

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] user signature modifications for posts

Post by brunoais » Fri Dec 28, 2012 8:38 am

EXreaction wrote:On the other hand, it does not seem like it is something we should add a bunch of code for and another query for, so perhaps using a bit of javascript and client side storage would be the best idea for a user by user basis.
Sounds like a good approach, for me!

User avatar
Ger
Registered User
Posts: 293
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: [RFC] user signature modifications for posts

Post by Ger » Fri Dec 28, 2012 9:05 am

EXreaction wrote:so perhaps using a bit of javascript and client side storage would be the best idea for a user by user basis.
IIRC, this is the way IPB does it. However, they come with a bunch of settings for each user group whether or not they can hide signatures of other users and whether or not their signatures can be hidden by others. UI is pretty simple; an X in the upper right corner of the signature div that appears when you hover it.

On a personal note: I don't find it very useful and I'm +1 on DavidIQ:
DavidIQ wrote:Sorry but I completely disagree with the idea as signatures will then become that much less useful. If you don't like long signatures then don't allow them. If you don't like big pictures in signatures then don't allow those.
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] user signature modifications for posts

Post by brunoais » Fri Dec 28, 2012 9:32 am

Ger wrote:On a personal note: I don't find it very useful and I'm +1 on DavidIQ:
DavidIQ wrote:Sorry but I completely disagree with the idea as signatures will then become that much less useful. If you don't like long signatures then don't allow them. If you don't like big pictures in signatures then don't allow those.
That's set using the ACP, right?
How about if only a small significant subset of the users don't like that kind of signatures but other like 'em? Doesn't it sound a better use case for this kind of thing?

User avatar
Ger
Registered User
Posts: 293
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: [RFC] user signature modifications for posts

Post by Ger » Fri Dec 28, 2012 9:50 am

I can imagine the use case. But in my opinion, on serious boards with focus on informative content, you don't want distracting signatures anyway, so you'd disable it with the mentioned settings in ACP. However, in -how do I say this- more social aimed, pub-like boards, it doesn't really matter for the board as a whole. Of course some users might still want to hide the signatures, they can disable the display of those in the UCP (board preferences -> display options). And of course, someone might want to hide some signatures but keep some other signatures and only in that case, this RFC comes in handy. But than I think:
EXreaction wrote:it does not seem like it is something we should add a bunch of code for and another query for
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] user signature modifications for posts

Post by brunoais » Fri Dec 28, 2012 10:18 am

Since when we need an extra query to the DB for that (if we do using js)?

User avatar
Ger
Registered User
Posts: 293
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: [RFC] user signature modifications for posts

Post by Ger » Fri Dec 28, 2012 10:23 am

When we're only using JS it wouldn't. I assumed you meant to use a server sided approach (storing the preference for each signature and each user in the DB and determine whether or not to load the sig for the viewing user).
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] user signature modifications for posts

Post by brunoais » Fri Dec 28, 2012 10:30 am

No... I meant a js only approach. This is not required to use the forums. It's just a fancy thing, so js alone is perfectly ok, IMO.
Just use the storage interface or cookies to store... Simple as that.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1831
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] user signature modifications for posts

Post by DavidIQ » Fri Dec 28, 2012 11:40 am

brunoais wrote:
Ger wrote:On a personal note: I don't find it very useful and I'm +1 on DavidIQ:
DavidIQ wrote:Sorry but I completely disagree with the idea as signatures will then become that much less useful. If you don't like long signatures then don't allow them. If you don't like big pictures in signatures then don't allow those.
That's set using the ACP, right?
How about if only a small significant subset of the users don't like that kind of signatures but other like 'em? Doesn't it sound a better use case for this kind of thing?
No, those settings are in the ACP. The forum admin is who decides what he wants to allow for signatures and what he doesn't. The user obviously shouldn't be in control of that.
brunoais wrote:No... I meant a js only approach. This is not required to use the forums. It's just a fancy thing, so js alone is perfectly ok, IMO.
Just use the storage interface or cookies to store... Simple as that.
Not sure how I feel about that. There are so many people that have issues with cookie and a certain EU cookie law that comes to mind...
Image

User avatar
Ger
Registered User
Posts: 293
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: [RFC] user signature modifications for posts

Post by Ger » Fri Dec 28, 2012 12:16 pm

DavidIQ wrote:There are so many people that have issues with cookie and a certain EU cookie law that comes to mind...
Functional cookies are allowed. Besides: how does it differ from login cookies etc.? These cookies don't need any private data, simply a comma separated list of user_id which signatures should be hidden would suffice. All signatures of user_id's in that list should get the display:none property.

However: I can imagine a big slowdown when a frequent user keeps adding more and more user_id's to that list. With only a handful it wouldn't matter, but with hundreds or maybe even thousands user_id's to search through with JS I think some browsers will have a hard time. That could potentially result in bad user experience.
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

Post Reply