Replace image buttons with css

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Replace image buttons with css

Post by Arty » Sun Nov 11, 2012 5:37 pm

This is Joas's idea. I couldn't find RFC matching that ticket, so made a new topic

Idea is to replace all current prosilver buttons with CSS buttons that use text instead of images.

Ticket: http://tracker.phpbb.com/browse/PHPBB3-10431
Pull request: https://github.com/phpbb/phpbb3/pull/1075

Please check pull request and post your suggestions.

Currently only large buttons such as "new topic" have been replaced. Implementation hasn't been tested properly with all browsers yet.


User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Replace image buttons with css

Post by imkingdavid » Sun Nov 11, 2012 7:00 pm

I'm assuming this only applies to the buttons that are primarily text (i.e. edit, quote, x, !, and ? from the post row, but not the email, yahoo, etc. buttons from the postbit). Anyway, I'm all for replacing images with CSS + text in any cases that makes sense.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Fyorl
Google Summer of Code Student
Posts: 27
Joined: Mon Apr 02, 2012 4:51 am
Location: UK
Contact:

Re: [RFC] Replace image buttons with css

Post by Fyorl » Sun Nov 11, 2012 9:49 pm

+1

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Replace image buttons with css

Post by Arty » Sun Nov 11, 2012 10:03 pm

imkingdavid wrote:I'm assuming this only applies to the buttons that are primarily text (i.e. edit, quote, x, !, and ? from the post row, but not the email, yahoo, etc. buttons from the postbit). Anyway, I'm all for replacing images with CSS + text in any cases that makes sense.
Yes, its only for text buttons. I don't see how it could be extended to other buttons.

User avatar
Vinny
Style Customisations
Style Customisations
Posts: 129
Joined: Thu May 20, 2010 4:01 am
Location: Brazil
Contact:

Re: [RFC] Replace image buttons with css

Post by Vinny » Mon Nov 12, 2012 4:35 am

Any plans for subsilver2?

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Replace image buttons with css

Post by Arty » Mon Nov 12, 2012 7:46 am

Vinny wrote:Any plans for subsilver2?
Yep, make new ugly buttons that are like worst buttons ever, put it in 3.1 to drive people away from that ancient style. But that would be a different RFC.

User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

Re: [RFC] Replace image buttons with css

Post by nickvergessen » Mon Nov 12, 2012 7:53 am

Well to summerize that shortly... subsilver2 is going to keep the current buttons
Member of the Development-TeamNo Support via PM

User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Replace image buttons with css

Post by Arty » Mon Nov 12, 2012 9:46 am

Changed text shadow a bit to make font look thicker than it is, changed font for iOS browsers because they didn't align Verdana correctly, added workaround for IE7 lack of support for basic pseudo classes.

Some screenshots (copy/pasted buttons from different screenshots. each mobile screenshot has several buttons with different zoom levels):

Desktop:
Image

Firefox on Android phone:
Image

Opera on Android phone:
Image

Safari on iOS:
Image

User avatar
Ger
Registered User
Posts: 293
Joined: Mon Jul 26, 2010 1:55 pm
Location: 192.168.1.100
Contact:

Re: [RFC] Replace image buttons with css

Post by Ger » Mon Nov 12, 2012 11:39 am

Somehow the font seems a bit fuzzy compared to current image buttons. Or is that just the screenshot quality?
Above message may contain errors in grammar, spelling or wrongly chosen words. This is because I'm not a native speaker. My apologies in advance.

Post Reply