phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[RFC] Ajax data attribute names

Publish your own request for comments or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.1/Ascraeus and 3.2/Arsia.

Re: [RFC] Ajax data attribute names

Postby nickvergessen » Thu Jul 12, 2012 5:52 pm

So the question is down to which we want to use:

we have 5 votes for phpbb- already I wouldnt really mind it being phpbb-ajax- or something like that, so it's more clear what it is about
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 350
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany

Re: [RFC] Ajax data attribute names

Postby naderman » Thu Jul 12, 2012 11:58 pm

Well everything needs to be prefixed with phpbb-, I think we all agree on that. You can further prefix some other item with phpbb-ajax if it is strictly related to ajax, but that's really a choice up to the implmentor. It's not that important.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1649
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: [RFC] Ajax data attribute names

Postby nickvergessen » Wed Jul 18, 2012 8:27 am

Should we add this to the coding guidelines than?
cheers nickvergessen :geek:
Member of phpBB Development-Team
No Support via PM — My MODs for phpBB 3.0.x
User avatar
nickvergessen
Development Team
Development Team
 
Posts: 350
Joined: Sun Oct 07, 2007 11:54 am
Location: Esslingen, Germany

Re: [RFC] Ajax data attribute names

Postby naderman » Thu Jul 19, 2012 1:29 am

Yes please
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1649
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: [RFC] Ajax data attribute names

Postby callumacrae » Thu Jul 19, 2012 8:19 pm

I'd like to point out (it was brought up in another thread) that phpbb-data-ajax-something is a completely invalid attribute name! data- has to come first, so data-phpbb-ajax-something is good.
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC] Ajax data attribute names

Postby psoTFX » Thu Jul 19, 2012 8:45 pm

I think the data- was assumed and the phpbb- was additional to it :P
User avatar
psoTFX
Registered User
 
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm

Re: [RFC] Ajax data attribute names

Postby callumacrae » Thu Jul 19, 2012 8:54 pm

nickvergessen wrote:As per viewtopic.php?f=108&t=43115 the data attribute should be prefixed with phpbb-data-*
"In JavaScript, there is a beautiful, elegant, highly expressive language that is buried under a steaming pile of good intentions and blunders"
—Douglas Crockford

View my MOD, phpBB Mobile
User avatar
callumacrae
Website Team
Website Team
 
Posts: 883
Joined: Tue Apr 27, 2010 9:37 am
Location: England

Re: [RFC] Ajax data attribute names

Postby psoTFX » Thu Jul 19, 2012 9:09 pm

callumacrae wrote:
nickvergessen wrote:As per viewtopic.php?f=108&t=43115 the data attribute should be prefixed with phpbb-data-*

Maybe not then :D
Last edited by psoTFX on Fri Jul 20, 2012 5:27 pm, edited 1 time in total.
User avatar
psoTFX
Registered User
 
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm

Re: [RFC] Ajax data attribute names

Postby bantu » Fri Jul 20, 2012 5:10 pm

nickvergessen wrote:naderman suggested to use data-phpbb- or something similar.

Yes please.
User avatar
bantu
3.0 Release Manager
3.0 Release Manager
 
Posts: 437
Joined: Thu Sep 07, 2006 11:22 am
Location: Karlsruhe, Germany

Previous

Return to [3.x] RFCs

Who is online

Users browsing this forum: No registered users and 13 guests