[RFC] Ajax data attribute names

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
nickvergessen
Former Team Member
Posts: 733
Joined: Sun Oct 07, 2007 11:54 am
Location: Stuttgart, Germany
Contact:

[RFC] Ajax data attribute names

Post by nickvergessen »

I had an IRC discussion with naderman today about the data attribute names we use for AJAX stuff.
Currently attributes are only prefixed with data- and we wondered, whether this prefix should be longer and uniquer.
naderman suggested to use data-phpbb- or something similar.

The question is, do you think this is neccessary and worth changing?
Member of the Development-TeamNo Support via PM
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: [RFC] Ajax data attribute names

Post by naderman »

As you already said I think this would be a good idea to avoid conflicts when integrating phpBB with other software.
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1862
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Ajax data attribute names

Post by DavidIQ »

+1 for the reasons Nils stated.
Image
User avatar
bonelifer
Community Team
Community Team
Posts: 113
Joined: Mon Jan 31, 2005 10:41 am

Re: [RFC] Ajax data attribute names

Post by bonelifer »

DavidIQ wrote:+1 for the reasons Nils stated.
++1
User avatar
nextgen Online
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC] Ajax data attribute names

Post by nextgen »

naderman wrote:As you already said I think this would be a good idea to avoid conflicts when integrating phpBB with other software.
good point, this avoids a conflict and would not duplicate calls, when using ajax must be careful about the above here.
More than one system would use the same prefix if not phpbb is assigned one.
*Imagine a signature super spectacular.*
Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Ajax data attribute names

Post by Oleg »

phpbb- prefix sounds good.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Ajax data attribute names

Post by imkingdavid »

Oleg wrote:phpbb- prefix sounds good.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
Meis2M
Registered User
Posts: 437
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: [RFC] Ajax data attribute names

Post by Meis2M »

phpbb- prefix

great idea +1
Last edited by Meis2M on Fri Jul 13, 2012 11:33 am, edited 1 time in total.
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Ajax data attribute names

Post by MichaelC »

Oleg wrote:phpbb- prefix sounds good.
+1
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.
User avatar
psoTFX
Registered User
Posts: 1984
Joined: Tue Jul 03, 2001 8:50 pm
Contact:

Re: [RFC] Ajax data attribute names

Post by psoTFX »

+1 with phpbb- as per others.
Post Reply