[RFC] Error, Success & Confirm Class

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
KnocksX
Registered User
Posts: 80
Joined: Thu Jul 19, 2012 2:03 am

Re: [RFC] Error, Success & Confirm Class

Post by KnocksX »

I fully support this, +1

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Error, Success & Confirm Class

Post by MichaelC »

Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Error, Success & Confirm Class

Post by Pony99CA »

Can we come up with a better term than "flash message"? When I first saw that, I wondered if phpBB was going to require Adobe Flash for messages. :roll:

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Error, Success & Confirm Class

Post by MichaelC »

Pony99CA wrote:Can we come up with a better term than "flash message"? When I first saw that, I wondered if phpBB was going to require Adobe Flash for messages. :roll:

Steve
Flash messages is both the correct term and it is widely used in development. I don't seen any problem with using it. All it takes is for a user to ask or google it and they will find out that its not adobe flash.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Senky
Extension Customisations
Extension Customisations
Posts: 315
Joined: Thu Jul 16, 2009 4:41 pm

Re: [RFC] Error, Success & Confirm Class

Post by Senky »

"Flash message" is absolutelly OK...

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Error, Success & Confirm Class

Post by Pony99CA »

Unknown Bliss wrote:
Pony99CA wrote:Can we come up with a better term than "flash message"? When I first saw that, I wondered if phpBB was going to require Adobe Flash for messages. :roll:
Flash messages is both the correct term and it is widely used in development. I don't seen any problem with using it. All it takes is for a user to ask or google it and they will find out that its not adobe flash.
Let me rephrase the request. On a developer board, "flash message" may be OK (although I hadn't heard the term until now and am still not sure what one looks like). However, if this has a chance of being exposed to non-developers (for example, the documentation could say "After pressing Submit, you'll see a flash message telling you whether the operation succeeded or failed."), we should find a better term. End users should not be forced to ask for clarification or Google something to understand it.

If end users will never see the term, then it's all good.
Senky wrote:"Flash message" is absolutelly OK...
Well, I guess that settles it. :roll:

But the overall proposal sounds like a good one. I always thought it strange that trigger_error was used for non-error messages.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1840
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Error, Success & Confirm Class

Post by DavidIQ »

Pony99CA wrote:If end users will never see the term, then it's all good.
This. Our users aren't developers so a layman's term for it would be best IMO.
Image

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Error, Success & Confirm Class

Post by MichaelC »

Pony99CA wrote:
Unknown Bliss wrote:
Pony99CA wrote:Can we come up with a better term than "flash message"? When I first saw that, I wondered if phpBB was going to require Adobe Flash for messages. :roll:
Flash messages is both the correct term and it is widely used in development. I don't seen any problem with using it. All it takes is for a user to ask or google it and they will find out that its not adobe flash.
Let me rephrase the request. On a developer board, "flash message" may be OK (although I hadn't heard the term until now and am still not sure what one looks like). However, if this has a chance of being exposed to non-developers (for example, the documentation could say "After pressing Submit, you'll see a flash message telling you whether the operation succeeded or failed."), we should find a better term. End users should not be forced to ask for clarification or Google something to understand it.

If end users will never see the term, then it's all good.
Senky wrote:"Flash message" is absolutelly OK...
Well, I guess that settles it. :roll:

But the overall proposal sounds like a good one. I always thought it strange that trigger_error was used for non-error messages.

Steve
Its more of a developer term. It means a message that comes up on the following screen, then disappears. We'll most likely use http://www.erichynds.com/examples/jquery-notify/ (click default notification).
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
Pony99CA
Registered User
Posts: 986
Joined: Sun Feb 08, 2009 2:35 am
Location: Hollister, CA
Contact:

Re: [RFC] Error, Success & Confirm Class

Post by Pony99CA »

Unknown Bliss wrote: Its more of a developer term. It means a message that comes up on the following screen, then disappears. We'll most likely use http://www.erichynds.com/examples/jquery-notify/ (click default notification).
Those are pretty cool. Thanks for the link.

Steve
Silicon Valley Pocket PC (http://www.svpocketpc.com)
Creator of manage_bots and spoof_user (ask me)
Need hosting for a small forum with full cPanel & MySQL access? Contact me or PM me.

KnocksX
Registered User
Posts: 80
Joined: Thu Jul 19, 2012 2:03 am

Re: [RFC] Error, Success & Confirm Class

Post by KnocksX »

They're beautiful

Post Reply