[RFC] Coding guidelines: var keyword in js per line

[callumacrae]

Okay, a better example:

What you're suggesting is the equivalent of suggesting that we have one global statement per variable in PHP. Nicer diffs, but not too logical.

[Erik Frèrejean]

Why don't you give a real argument against this proposal rather then "examples" which either don't have anything to do with the subject or that reflect on something that is already phased out?
As far as I'm concerned there is really no hurt, you just have to type 3 additional characters rather than 3 spaces to keep things aligned.

[callumacrae]

I don't see any advantages, and it isn't at all DRY.

[wGEric]

Why don't you give a real argument against this proposal rather then "examples" which either don't have anything to do with the subject or that reflect on something that is already phased out?
As far as I'm concerned there is really no hurt, you just have to type 3 additional characters rather than 3 spaces to keep things aligned.

There isn't really an argument. Changing the style of your code so that the diffs are pretty isn't a good argument. If you minify the Javascript it will probably combine all of them into one var statement so it doesn't matter there. You are using strict mode so global variables aren't an issue. It all comes down to what people prefer.

Code: Select all

var a;
var b;
var c;
var d;

Or

Code: Select all

var a,
    b,
    c,
    d;

I prefer one var because it is quicker/easier to type. Really you shouldn't be adding 3 spaces since phpBB uses tabs (did this change?). Multiple var statements add clutter that doesn't really add anything to the code.

[Arty]

-1

This RFC is an equivalent of putting each global declaration in PHP code on its own line, like

Code: Select all

global $db, $user, $session, $whatever;

being replaced with

Code: Select all

global $db;
global $user;
global $session;
global $whatever;

for sake of cleaner diffs.

Does that PHP code make sense? No, it doesn't. Nether does this RFC.

[MichaelC]

-1

This RFC is an equivalent of putting each global declaration in PHP code on its own line, like

Code: Select all

global $db, $user, $session, $whatever;

being replaced with

Code: Select all

global $db;
global $user;
global $session;
global $whatever;

for sake of cleaner diffs.

Does that PHP code make sense? No, it doesn't. Nether does this RFC.

+1

[Oleg]

-1

This RFC is an equivalent of putting each global declaration in PHP code on its own line, like

Code: Select all

global $db, $user, $session, $whatever;

being replaced with

Code: Select all

global $db;
global $user;
global $session;
global $whatever;

for sake of cleaner diffs.

Does that PHP code make sense? No, it doesn't. Nether does this RFC.

You completely misunderstood the proposal. Please read it carefully. wGEric correctly understood it:

It all comes down to what people prefer.

Code: Select all

var a;
var b;
var c;
var d;

Or

Code: Select all

var a,
    b,
    c,
    d;

[Arty]

You completely misunderstood the proposal. Please read it carefully.

I don't think I did. In JavaScript it is usual practice to declare each variable on its own line, so adding "var" to each line is equivalent to what I wrote.

That is unless you wanted to suggest something else from that article you linked to. In that case please do elaborate, not just link to long article.

[bantu]

Each line in JS that declares variables should have its own var keyword, in order for diffs to not change irrelevant lines.

See also: http://benalman.com/news/2012/05/multip ... avascript/

I support this.

[naderman]

Okay, a better example:

What you're suggesting is the equivalent of suggesting that we have one global statement per variable in PHP. Nicer diffs, but not too logical.

-1

This RFC is an equivalent of putting each global declaration in PHP code on its own line, like

Code: Select all

global $db, $user, $session, $whatever;

being replaced with

Code: Select all

global $db;
global $user;
global $session;
global $whatever;

for sake of cleaner diffs.

Does that PHP code make sense? No, it doesn't. Nether does this RFC.

I would actually be in favour of that. However in new code we are no longer using global variables, and we decided not to rewrite large sections of code in 3.x for coding style reasons, so there's no point in doing that for global variables.

On the subject of this RFC +1