[RFC] Don't show banned members birthdays

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

[RFC] Don't show banned members birthdays

Post by MichaelC »

Currently, if you ban a spam bot, then it obviously can't post. However they still show up on Birthday. Sometimes the spambots select the same day (paricularly the 1st of Jan and 31st December) and result in days such as today.

I suggest that when members are banned they no longer show in the Birthdays List in the Index Page footer.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
callumacrae
Former Team Member
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Don't show banned members birthdays

Post by callumacrae »

+1
Made by developers, for developers!
My blog

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Don't show banned members birthdays

Post by imkingdavid »

Sounds good to me. Should be a simple added condition to make sure the user about to be displayed is not banned.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Meis2M
Registered User
Posts: 434
Joined: Fri Apr 23, 2010 10:18 am
Contact:

Re: [RFC] Don't show banned members birthdays

Post by Meis2M »

+1 and very good idea.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1845
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Don't show banned members birthdays

Post by DavidIQ »

I would consider this more a bug than a feature.
Image

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Don't show banned members birthdays

Post by imkingdavid »

Has anyone made a ticket? ;)
DavidIQ wrote:I would consider this more a bug than a feature.
bug != feature? :?
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1845
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Don't show banned members birthdays

Post by DavidIQ »

This was written up as an RFC which indicates something is working as expected but we would like to change it? To me that is not the case. This is a bug in the current Olympus branch.
Image

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Don't show banned members birthdays

Post by MichaelC »

hm... I'd say its more an improvement which could be either. Anyway, I'll do this when I get a chance for develop-olympus so it can be merged into either branch.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Don't show banned members birthdays

Post by Oleg »

It is a behavior change, therefore an RFC. RFCs do not necessarily have to be for new features.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1845
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Don't show banned members birthdays

Post by DavidIQ »

I still say it's a bug. Why would you display someone's birthday that has been banned? Makes no sense and I can't think of a reason to show them by default. It was more an oversight by those that added in the feature. But that's ok...if you all say it was intended to show banned users' birthdays on the list then it's a "behavior change" and it's an RFC we're looking for. ;-)
Image

Post Reply