[RFC] GeSHi highlighting

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
Jacob
Registered User
Posts: 100
Joined: Wed Jan 04, 2012 1:41 pm

Re: [RFC] GeSHi highlighting

Post by Jacob » Fri May 11, 2012 2:03 am

DavidIQ wrote:+1 for being kept as an extension.
Same here.

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] GeSHi highlighting

Post by brunoais » Fri May 11, 2012 5:50 am

DavidIQ wrote:+1 for being kept as an extension.
Besides, that's what it was intended for, right? (it was intended as a MOD and now we are thinking it as an extension. Basically the same)

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1831
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] GeSHi highlighting

Post by DavidIQ » Sat May 12, 2012 12:46 pm

No. This was not an RFC to change the MOD to an extension. There is no need to have RFCs for that. This was an RFC to include it in the core.
Image

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] GeSHi highlighting

Post by AliasM2K » Sat May 12, 2012 10:39 pm

SMF do have syntax highlighting implemented at its core... So do many other bulletin board softwares. So, I dont think it is bad to implement it at core... Performance issues have to be considered.

User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

Re: [RFC] GeSHi highlighting

Post by Erik Frèrejean » Mon May 14, 2012 10:07 am

AliasM2K wrote:SMF do have syntax highlighting implemented at its core... So do many other bulletin board softwares. So, I dont think it is bad to implement it at core... Performance issues have to be considered.
"BB solution xyz has feature abc" has never been an reason for something to be included in phpBB.
Available on .com
Support Toolkit developer

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] GeSHi highlighting

Post by imkingdavid » Mon May 14, 2012 12:27 pm

AliasM2K wrote:SMF do have syntax highlighting implemented at its core... So do many other bulletin board softwares. So, I dont think it is bad to implement it at core... Performance issues have to be considered.
It might not be "bad", but ultimately, features are included because they will be helpful to the majority of phpBB boards. Only one small subset (i.e. programming-oriented boards) will even have a need for syntax highlighting. So, for features that only cater to a certain group of boards, we encourage them being implemented as extensions.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
tbackoff
Registered User
Posts: 180
Joined: Sat Jun 12, 2010 3:25 am

Re: [RFC] GeSHi highlighting

Post by tbackoff » Mon May 14, 2012 7:12 pm

imkingdavid wrote:features are included because they will be helpful to the majority of phpBB boards. Only one small subset (i.e. programming-oriented boards) will even have a need for syntax highlighting. So, for features that only cater to a certain group of boards, we encourage them being implemented as extensions.
I'm interested in hearing how this is "helpful to the mjority of phpBB boards":

Code: Select all

<?php
print 'This is PHP code, a default feature in 3.0.x';
?>
Is this being removed in 3.1.x? :?

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1831
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] GeSHi highlighting

Post by DavidIQ » Mon May 14, 2012 7:33 pm

I think it should. If someone wants true syntax highlighting they can drop in an extension. I personally don't like the fact that we have the "code=PHP" syntax available in the default package. Plus it messes up tabs.
Image

User avatar
Erik Frèrejean
Registered User
Posts: 207
Joined: Thu Oct 25, 2007 2:25 pm
Location: surfnet
Contact:

Re: [RFC] GeSHi highlighting

Post by Erik Frèrejean » Mon May 14, 2012 8:33 pm

t_backoff wrote:
imkingdavid wrote:features are included because they will be helpful to the majority of phpBB boards. Only one small subset (i.e. programming-oriented boards) will even have a need for syntax highlighting. So, for features that only cater to a certain group of boards, we encourage them being implemented as extensions.
I'm interested in hearing how this is "helpful to the mjority of phpBB boards":

Code: Select all

<?php
print 'This is PHP code, a default feature in 3.0.x';
?>
Is this being removed in 3.1.x? :?
I'm not a big fan of removing features unless there is a grounded reason for that (and an RFC was created for that ;)). But I quite frankly never understood why the php syntax highlighting was added in the first place.
Available on .com
Support Toolkit developer

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] GeSHi highlighting

Post by MichaelC » Mon May 14, 2012 8:41 pm

t_backoff wrote:
imkingdavid wrote:features are included because they will be helpful to the majority of phpBB boards. Only one small subset (i.e. programming-oriented boards) will even have a need for syntax highlighting. So, for features that only cater to a certain group of boards, we encourage them being implemented as extensions.
I'm interested in hearing how this is "helpful to the mjority of phpBB boards":

Code: Select all

<?php
print 'This is PHP code, a default feature in 3.0.x';
?>
Is this being removed in 3.1.x? :?
There was a different mentality to which features should be added and who decided which features should be added then. It was probably a developer who thought it would be helpful to him, not thinking if it was helpful to the majority of the phpBB user base and there wasn't much discussion about things then for others to object. Now we focus more on who would it be helpful too and more people can object (or agree).
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Post Reply