phpBB

Development Discussion Board

phpBB's testing ground of bleeding edge code
Advanced search

[GSoC] Search Backend Refactoring

Publish your own request for comments or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.1/Ascraeus and 3.2/Arsia.

Re: [GSoC] Search Backend Refactoring

Postby *Daniel » Tue Jul 10, 2012 1:26 am

Also I should add that many people will have exec( ) disabled for the secturity of their servers as well.
Oleg wrote:This topic's title takes the prize for most errors per word (3 in 4).
*Daniel
Registered User
 
Posts: 161
Joined: Mon Feb 08, 2010 3:42 am

Re: [GSoC] Search Backend Refactoring

Postby Oleg » Wed Jul 11, 2012 10:20 pm

phpbb should work with a separately launched sphinx (appropriately configured by the system administrator).

Does exec work some of the time or never?
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: [GSoC] Search Backend Refactoring

Postby naderman » Thu Jul 12, 2012 2:44 am

We discussed this on IRC a bit and came to the conclusion that there was no need for any of the exec code. A properly configured instance of sphinx wouldn't allow the webserver to control the daemon anyway. And sphinx isn't exactly for shared hosting, so one can assume that it'll be setup by someone who has at least some basic understanding of system administration.
www.naderman.de
Move your forum to Forumatic - we'll take care of maintenance & spam
User avatar
naderman
Development Team Leader
Development Team Leader
 
Posts: 1650
Joined: Sun Jan 11, 2004 2:11 am
Location: Karlsruhe, Germany

Re: [GSoC] Search Backend Refactoring

Postby Oleg » Sat Jul 28, 2012 5:33 am

Sphinx has been merged.
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: [GSoC] Search Backend Refactoring

Postby Senky » Mon Jul 30, 2012 6:55 pm

Just wondering if this problem does not impact new search backend... (it is about egosearch at phpbb.com)
Senky
Registered User
 
Posts: 222
Joined: Thu Jul 16, 2009 4:41 pm

Re: [GSoC] Search Backend Refactoring

Postby Oleg » Mon Jul 30, 2012 11:39 pm

Are you able to reproduce any of those issues on develop?
Oleg
3.1 Release Manager
3.1 Release Manager
 
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am

Re: [GSoC] Search Backend Refactoring

Postby Senky » Fri Aug 03, 2012 6:56 pm

Will try with this post and edit it after result found...

EDIT: no, it updated instantly.

I just asked, fot us not to be wondered why something like this happens in case...
Senky
Registered User
 
Posts: 222
Joined: Thu Jul 16, 2009 4:41 pm

Re: [GSoC] Search Backend Refactoring

Postby dhruv.goel92 » Wed Aug 08, 2012 11:38 am

So PostgreSQL fulltext search and sphinx search have already been integrated. Sphinx error reporting has been improved with proper logging and error display in case search fails. I am working on improving postgresql fulltext search as it mis-behaves on -foo treating it like foo. Access specifiers will be added and ACP UI code which is currently passed on as a variable will be moved to a new HTML file like: adm/style/search_fulltext_sphinx.html
Intend to write some tests too. Is there anything else I am missing out on, that can be improved/ introduced in phpBB search backends?
dhruv.goel92
Development Team
Development Team
 
Posts: 20
Joined: Sun Mar 18, 2012 9:30 pm

Previous

Return to [3.x] RFCs

Who is online

Users browsing this forum: Google [Bot] and 13 guests