[RFC] AJAX Quick Edit

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Fri Apr 06, 2012 10:13 am

brunoais wrote:
AliasM2K wrote:
DavidIQ wrote:Go look at our customisations database and try editing a post. That is what Quick Edit should be doing, not some modal. That makes it less quick and it blocks other posts which you could be basing your edit on.
Ok. Just tried out implementing what I thought would be good...

Anyway, what about an inline text area that is hidden, which fades in on clicking the edit button? I think that would do for a quick edit...
Can become too much data for a single thread. This means to the browser to download the double of the information for editable posts which can become heavy.
I wouldn't describe it as heavy, but it's not required.
Made by developers, for developers!
My blog

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] AJAX Quick Edit

Post by AliasM2K » Sat Apr 07, 2012 12:30 am

callumacrae wrote:You should send an AJAX request requesting the BBCode, then create the textarea and insert the BBCode into it.
That have be done... The text area should be filled with the post's bbcode. Else, what could be edited?
callumacrae wrote:I wouldn't describe it as heavy, but it's not required.
I think so too... An inline editor, using a bit of AJAX to load bbcode won't be that heavy.

Personally, I'd love to implement this patch on phpBB... I know this is not the right place to ask, but how am I to contribute to the code?

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Sat Apr 07, 2012 6:52 am

Create a ticket on the tracker. Then clone the phpbb repo from GitHub, and branch the develop branch into ticket/ticketid. Make your changes, commit them, and then push them and send a PR.

http://wiki.phpbb.com/Git
Made by developers, for developers!
My blog

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] AJAX Quick Edit

Post by AliasM2K » Sat Apr 07, 2012 11:17 pm

callumacrae wrote:Create a ticket on the tracker. Then clone the phpbb repo from GitHub, and branch the develop branch into ticket/ticketid. Make your changes, commit them, and then push them and send a PR.

http://wiki.phpbb.com/Git
Thanks... Attempting the patch now.

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] AJAX Quick Edit

Post by AliasM2K » Sun Apr 08, 2012 11:53 pm

And, here is a live demo of my implementation plan.

Using markItUp jQuery plugin for fun, and also the buttons Full Editor and Submit are dummies. The idea is to hide the post and display the editor.

The demo is not a big deal... I am just posting it to see if that is what you expected.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] AJAX Quick Edit

Post by brunoais » Mon Apr 09, 2012 8:31 am

AliasM2K wrote:The demo is not a big deal... I am just posting it to see if that is what you expected.
That kind of behaviour is what I'm after.
Check this too:
http://userscripts.org/scripts/show/11064
It also has the same idea.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Mon Apr 09, 2012 9:33 am

AliasM2K wrote:And, here is a live demo of my implementation plan.

Using markItUp jQuery plugin for fun, and also the buttons Full Editor and Submit are dummies. The idea is to hide the post and display the editor.

The demo is not a big deal... I am just posting it to see if that is what you expected.
Demo doesn't appear to be working properly (or I'm getting confused).

Take a look at this, it is kinda what I'm expecting (although obviously this is only a very basic example): http://jsfiddle.net/ZabMY/
Made by developers, for developers!
My blog

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] AJAX Quick Edit

Post by AliasM2K » Tue Apr 10, 2012 12:27 am

callumacrae wrote: Demo doesn't appear to be working properly (or I'm getting confused).

Take a look at this, it is kinda what I'm expecting (although obviously this is only a very basic example): http://jsfiddle.net/ZabMY/
Got the idea... Thanks...

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 123
Joined: Thu Sep 09, 2010 11:36 am
Location: Munich, Germany

Re: [RFC] AJAX Quick Edit

Post by Marc » Tue Apr 10, 2012 4:36 pm

I've been working on more than one Quickedit MOD for a while now.
That's what it currently looks like:
http://www.youtube.com/watch?v=X8AkYLQTwO4

BBCode is not necessary but a lot of people asked for it, which is why I added it.

I pasted the code that is running all that here:
https://gist.github.com/2352689

Not sure if I missed something but that should be all.
I also pasted the whole jquery_functions.php (unnecessary parts have been stripped) so you can actually see what the variables are doing what.
It's definitely not perfect but should do the job.

User avatar
jsebean
Registered User
Posts: 165
Joined: Wed Nov 17, 2010 1:40 am
Location: Atlantic Canada

Re: [RFC] AJAX Quick Edit

Post by jsebean » Tue Apr 10, 2012 4:49 pm

marc1706 wrote:I've been working on more than one Quickedit MOD for a while now.
That's what it currently looks like:
http://www.youtube.com/watch?v=X8AkYLQTwO4

BBCode is not necessary but a lot of people asked for it, which is why I added it.

I pasted the code that is running all that here:
https://gist.github.com/2352689

Not sure if I missed something but that should be all.
I also pasted the whole jquery_functions.php (unnecessary parts have been stripped) so you can actually see what the variables are doing what.
It's definitely not perfect but should do the job.
Very nice mod indeed my favorite part of jquery base is the quick reply without refresh.
-Jonah

Post Reply