[RFC] AJAX Quick Edit

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
Post Reply
User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] AJAX Quick Edit

Post by VSE » Thu Apr 05, 2012 7:42 am

AliasM2K wrote:
callumacrae wrote:I'd like to see something like this, but less ugly: http://cl.ly/0b1P280V0Z3S2j2p2O3M
What about this? ;)
Image
No it should not be in a modal. It should take place within the post area, just as it works in the customization database at phpbb.com
Has an irascible disposition.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Thu Apr 05, 2012 7:47 am

AliasM2K wrote:
callumacrae wrote:I'd like to see something like this, but less ugly: http://cl.ly/0b1P280V0Z3S2j2p2O3M
What about this? ;)
Image
I'm not a fan. When you start popping stuff out at the users, it disrupts the experience, and can be a bit disorientating.
Made by developers, for developers!
My blog

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1731
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] AJAX Quick Edit

Post by DavidIQ » Thu Apr 05, 2012 10:36 am

Go look at our customisations database and try editing a post. That is what Quick Edit should be doing, not some modal. That makes it less quick and it blocks other posts which you could be basing your edit on.
Image

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Thu Apr 05, 2012 12:19 pm

DavidIQ wrote:Go look at our customisations database and try editing a post. That is what Quick Edit should be doing, not some modal. That makes it less quick and it blocks other posts which you could be basing your edit on.
I linked to something like that a while ago in this thread: http://cl.ly/0b1P280V0Z3S2j2p2O3M
Made by developers, for developers!
My blog

User avatar
galaxyAbstractor
Google Summer of Code Student
Posts: 17
Joined: Sun Sep 25, 2011 7:40 pm

Re: [RFC] AJAX Quick Edit

Post by galaxyAbstractor » Thu Apr 05, 2012 1:59 pm

I like this idea. When a user is done editing and press the submit button, should the user be redirected to a page that confirms the edit, or would the textbox be replaced with the new post directly (and maybe some message about confirmation)?

User avatar
VSE
Extension Customisations
Extension Customisations
Posts: 670
Joined: Mon Mar 08, 2010 9:18 am

Re: [RFC] AJAX Quick Edit

Post by VSE » Thu Apr 05, 2012 4:37 pm

galaxyAbstractor wrote:When a user is done editing and press the submit button, should the user be redirected to a page that confirms the edit, or would the textbox be replaced with the new post directly (and maybe some message about confirmation)?
The text box will be dynamically replaced with the new edit. No redirects or confirmations.
Has an irascible disposition.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Thu Apr 05, 2012 4:48 pm

VSE+ wrote:
galaxyAbstractor wrote:When a user is done editing and press the submit button, should the user be redirected to a page that confirms the edit, or would the textbox be replaced with the new post directly (and maybe some message about confirmation)?
The text box will be dynamically replaced with the new edit. No redirects or confirmations.
+1
Made by developers, for developers!
My blog

User avatar
AliasM2K
Registered User
Posts: 82
Joined: Tue Mar 27, 2012 2:33 am

Re: [RFC] AJAX Quick Edit

Post by AliasM2K » Thu Apr 05, 2012 11:35 pm

DavidIQ wrote:Go look at our customisations database and try editing a post. That is what Quick Edit should be doing, not some modal. That makes it less quick and it blocks other posts which you could be basing your edit on.
Ok. Just tried out implementing what I thought would be good...

Anyway, what about an inline text area that is hidden, which fades in on clicking the edit button? I think that would do for a quick edit...

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] AJAX Quick Edit

Post by callumacrae » Fri Apr 06, 2012 4:32 am

AliasM2K wrote:
DavidIQ wrote:Go look at our customisations database and try editing a post. That is what Quick Edit should be doing, not some modal. That makes it less quick and it blocks other posts which you could be basing your edit on.
Ok. Just tried out implementing what I thought would be good...

Anyway, what about an inline text area that is hidden, which fades in on clicking the edit button? I think that would do for a quick edit...
You should send an AJAX request requesting the BBCode, then create the textarea and insert the BBCode into it.
Made by developers, for developers!
My blog

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] AJAX Quick Edit

Post by brunoais » Fri Apr 06, 2012 9:35 am

AliasM2K wrote:
DavidIQ wrote:Go look at our customisations database and try editing a post. That is what Quick Edit should be doing, not some modal. That makes it less quick and it blocks other posts which you could be basing your edit on.
Ok. Just tried out implementing what I thought would be good...

Anyway, what about an inline text area that is hidden, which fades in on clicking the edit button? I think that would do for a quick edit...
Can become too much data for a single thread. This means to the browser to download the double of the information for editable posts which can become heavy.

Post Reply