[RFC] Multiple file uploads

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
Post Reply
User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Multiple file uploads

Post by brunoais » Thu Mar 29, 2012 2:36 pm

How gracefully does it go when the user does not have js?

_hsr
Registered User
Posts: 42
Joined: Mon Mar 26, 2012 7:06 am

Re: [RFC] Multiple file uploads

Post by _hsr » Thu Mar 29, 2012 3:47 pm

Smoothly the old way !
There is a text here !

_hsr
Registered User
Posts: 42
Joined: Mon Mar 26, 2012 7:06 am

Re: [RFC] Multiple file uploads

Post by _hsr » Tue Apr 24, 2012 1:13 am

handing over all the responsibility to fyorl, take it home buddy ;)
There is a text here !

User avatar
Fyorl
Google Summer of Code Student
Posts: 27
Joined: Mon Apr 02, 2012 4:51 am
Location: UK
Contact:

Re: [RFC] Multiple file uploads

Post by Fyorl » Tue Apr 24, 2012 11:30 am

Thank you very much. Do you have a git branch I can clone for this?

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Multiple file uploads

Post by Oleg » Tue Apr 24, 2012 2:36 pm

Oleg wrote:So then we don't need any of flash/silverlight/whatever bits at all, and can just go with html5 exclusively?
My preference is to implement only html5 in phpbb if this works on all current browsers, with a falback to html4 (existing behavior in 3.0).

User avatar
Fyorl
Google Summer of Code Student
Posts: 27
Joined: Mon Apr 02, 2012 4:51 am
Location: UK
Contact:

Re: [RFC] Multiple file uploads

Post by Fyorl » Tue Apr 24, 2012 4:01 pm

Oleg wrote:My preference is to implement only html5 in phpbb if this works on all current browsers, with a falback to html4 (existing behavior in 3.0).
I agree, Flash is dead and Silverlight was never alive to begin with. Everything can be done with pure HTML5 now (chunked upload, streamed upload, image resizing etc.).

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Multiple file uploads

Post by Oleg » Tue Apr 24, 2012 5:32 pm

http://www.plupload.com/punbb/viewtopic.php?id=1685 was the plupload vulnerability.

If we only use html5 would we be vulnerable to flash vulnerabilities like this?

User avatar
Fyorl
Google Summer of Code Student
Posts: 27
Joined: Mon Apr 02, 2012 4:51 am
Location: UK
Contact:

Re: [RFC] Multiple file uploads

Post by Fyorl » Tue Apr 24, 2012 7:14 pm

That vulnerability exists in the compiled SWF file, therefore if we do not use the SWF at all then there should be no vulnerability.

_hsr
Registered User
Posts: 42
Joined: Mon Mar 26, 2012 7:06 am

Re: [RFC] Multiple file uploads

Post by _hsr » Wed Apr 25, 2012 2:41 am

html5 is not available in all browsers as of now. I say we include flash and/or silverlight in the package and let the admins choose the preferred framework. It is just a matter of including a string in it's configuration.

@fyorl, I had made a branch on github for this project, will update it with some more commits, you can dig up from there. And I suggest you do not use the plupload github source, but their stable release package.
There is a text here !

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Multiple file uploads

Post by Oleg » Wed Apr 25, 2012 3:38 am

Which browsers currently support everything we want via html5?

Post Reply