[RFC] Bigger topic title lenght limit

These requests for comments/change have lead to an implemented feature that has been successfully merged into the 3.1/Ascraeus branch. Everything listed in this forum will be available in phpBB 3.1.
ecwpa
Registered User
Posts: 181
Joined: Mon Jan 24, 2005 2:10 am
Contact:

[RFC] Bigger topic title lenght limit

Post by ecwpa » Thu Feb 09, 2012 1:30 am

How many times have you guys hit the topic character limit? I know I did, especially if its a news forum which I know it isn't the primary reason to use phpBB but I think its a fair request.

Doing changes directly on the database could be a bit scary if you don't know what you're doing. So I'm requesting to make more space for topic titles or let admins configure it they want to, because I know this could break some templates.

Ticket: http://tracker.phpbb.com/browse/PHPBB3-10640
PR: https://github.com/phpbb/phpbb3/pull/571
Last edited by Vinny on Sat Jun 02, 2012 6:26 pm, edited 1 time in total.
Reason: Adds ticket and PR links
Slightly better English than it was in 2005, still improving :D

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Bigger topic title lenght limit

Post by brunoais » Thu Feb 09, 2012 9:06 am

By stating bigger.... How bigger are you thinking?

Oleg
Posts: 1150
Joined: Tue Feb 23, 2010 2:38 am
Contact:

Re: [RFC] Bigger topic title lenght limit

Post by Oleg » Fri Feb 10, 2012 7:16 am

I think we should definitely expand it as I ran into it recently on area51. Maybe to 2x the current size.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Bigger topic title lenght limit

Post by MichaelC » Fri Feb 10, 2012 8:04 am

Oleg wrote:I think we should definitely expand it as I ran into it recently on area51. Maybe to 2x the current size.
+1. Its way too easy to run into it at the moment. Its 64 characters.

I'll take a look at a patch for this at the weekend if nobody else is.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
callumacrae
Infrastructure Team
Infrastructure Team
Posts: 1046
Joined: Tue Apr 27, 2010 9:37 am
Location: England
Contact:

Re: [RFC] Bigger topic title lenght limit

Post by callumacrae » Fri Feb 10, 2012 9:35 am

Unknown Bliss wrote:
Oleg wrote:I think we should definitely expand it as I ran into it recently on area51. Maybe to 2x the current size.
+1. Its way too easy to run into it at the moment. Its 64 characters.

I'll take a look at a patch for this at the weekend if nobody else is.
Time to learn how the database updater thing works :P
Made by developers, for developers!
My blog

ecwpa
Registered User
Posts: 181
Joined: Mon Jan 24, 2005 2:10 am
Contact:

Re: [RFC] Bigger topic title lenght limit

Post by ecwpa » Fri Feb 10, 2012 2:21 pm

Oleg wrote:I think we should definitely expand it as I ran into it recently on area51. Maybe to 2x the current size.
That'll be more than enough for me, thanks!
Last edited by ecwpa on Fri Feb 10, 2012 9:46 pm, edited 1 time in total.
Slightly better English than it was in 2005, still improving :D

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Bigger topic title lenght limit

Post by imkingdavid » Fri Feb 10, 2012 3:31 pm

For whomever is going to do this, some additional info: The "topic_title" column in the phpbb_topics table is a VARCHAR(255). So the limit is in the software, meaning that you'll need to look, likely, in posting.php or functions_posting.php to find where it is limiting the length.

Also, the post_title length should be updated accordingly.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Jacob
Registered User
Posts: 100
Joined: Wed Jan 04, 2012 1:41 pm

Re: [RFC] Bigger topic title lenght limit

Post by Jacob » Fri Feb 10, 2012 3:56 pm

Info: Sorry, I still don't know how to use git. I'll try to learn.

Edit:
imkingdavid wrote:Also, the post_title length should be updated accordingly.
I think it's the same function (truncate_string).

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Bigger topic title lenght limit

Post by MichaelC » Fri Feb 10, 2012 4:05 pm

I don't think we need an ACP setting for this but thanks for both links.

Do we want to go to 120/124 or 100/104 or 200/204 (second number is for if its a reply it needs to have topic title length plus 4 characters. Having them the same would chop of a 100 char topic title by 4 chars in all replies. - Re: (Space) TOPICSUBJECT.

I'll put up a PR tonight with 120 for now.
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Bigger topic title lenght limit

Post by MichaelC » Sat Feb 11, 2012 1:49 am

Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

Post Reply