[RFC] New Forum permission for viewing other users' topics

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

[RFC] New Forum permission for viewing other users' topics

Post by brunoais » Sun Jan 29, 2012 1:58 pm

Introduction
A feature many forums deliver (specially paid ones) which is a permission to allow the user who created the topic to view it.
With this permission, the user can only view the topics in that forum that he created himself (he's the author or the 1st post. Something like me in this topic ;) ).
According to my small investigation:
  • When a user wants to protest something, sometimes it's better not to show the topic itself to the public depending the way the conversation is going.
  • When the moderators/administration wants to isolate a post to discuss it, it's better not to allow other people than the poster (in order to justify the post, for example) to view the isolated post (sometimes things get really nasty :twisted: ).
  • Sometimes the forum admins likes to have a system where the user can have private support without intervention of other users and when it's solved, the topic is moved and other users may come and discuss the result. (this is rare but still does exist)
Proposal
Add a new permission under
Can read forum
for this feature.

How the permission works:
if can read forum is no OR never -> This option should he hidden using javascript. Any option selected will take no effect.
if can read forum is Yes -> This option should be available. The meanings are:
Yes -> It works exactly like the system is now. The Yes will be used as the default for the current roles.
No OR never -> The user can only see the topics in which he is the author

Name the option
I don't know which name is better for this option.
  1. Can read topics started by others
  2. Can view other users' topics
  3. Can view topics started by other members
Acording to a small discussion, #3 seems the best option. If you find an even better one, propose away :)


Source of data: Recently, a pull for 1 month in a private sub-forum in a forum. 68% -> yes 10% -> no 22% -> I don't use it but I believe it is useful.
[EDIT: Fixed some syntax mistakes and a missing bold]

EDIT: Due to the "spirit" of the permissions system, this option, when set to yes should allow something more then then set to no.
Any more comments?
Last edited by imkingdavid on Thu May 03, 2012 7:24 pm, edited 6 times in total.
Reason: More descriptive title

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC]New Forum permission

Post by MichaelC » Mon Jan 30, 2012 12:20 am

+1
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC]New Forum permission

Post by brunoais » Tue Jan 31, 2012 9:20 pm

@dev team!
May I develop this functionality?

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC]New Forum permission

Post by imkingdavid » Tue Jan 31, 2012 10:16 pm

You're welcome to work on it if you'd like. I'm not against such a new permission.

EDIT: And if you would like to do the javascript hiding/showing based on other permissions, that's a big +1
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC]New Forum permission

Post by brunoais » Tue Jan 31, 2012 10:37 pm

I'll do anything needed for this added functionality.
I just question this because I don't want to develop and then get refused or ignored.

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC]New Forum permission

Post by imkingdavid » Tue Jan 31, 2012 10:42 pm

brunoais wrote:I'll do anything needed for this added functionality.
I just question this because I don't want to develop and then get refused or ignored.
Well unfortunately it can take a while for things to get reviewed. We're not ignoring you, it just takes time for stuff to happen. I even have a couple of pull requests that are basically ready to be merged but are waiting for people to review them or for other patches to be done first.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC]New Forum permission

Post by brunoais » Wed Feb 01, 2012 11:03 am

imkingdavid wrote: Well unfortunately it can take a while for things to get reviewed. We're not ignoring you, it just takes time for stuff to happen. I even have a couple of pull requests that are basically ready to be merged but are waiting for people to review them or for other patches to be done first.
Hum... Did I explain wrong? Maybe I did. Here's a better, more complete one.
See something like this:
viewtopic.php?f=108&t=42431
or even:
viewtopic.php?f=108&t=42477
It may sound like a great to the thread OP but the community just says no.
At least for me, when I post, I like to receive review. After I know people like it, I need to know if the ones that will analyze or know how analyze works approve or disapprove the idea. In those 2 it was quick to get to that idea. In some of mine I have already written (I actually still have 5 in which 2 scratched right away and think of doing a MOD instead so I still have 3 in the drawing board being improved so that I can propose) they don't get a discussion. Not much people don't answer them and then I don't understand how the community of this forum relates to them (likes, doesn't like, needs more discussion, has improvements to propose, etc...). Did you get the idea?

The thing is simple. If I make code for phpbb 3.1 I don't care much if the code takes time to get reviewed people here are working for free. I just need to know if I'm working for the right idea. If I have an idea, no one acknowledges saying ok or nook for it or suggest improvements I don't know if it's a good idea or not or even if it will be rejected when trying to add to phpbb core because they don't like the idea. I don't really know how things work around here, I came from a different open source project (where the staff went from 10 to 0 and seems now abandoned (sorry, I won't tell which project was)) where adding code is definitely different from here so I need some help fitting in. When I make code, in this case, for phpbb 3.1 and the code is ready before 3.1 goes to beta, I want the feature in 3.1. It may take 1 week, 1 month, or even 5 months but I want my code reviewed and I want an answer so that I can make some code changes, if needed, to allow it to pass in the review (I hope I wasn't too brute with words ;) ).
I hope I was able to express myself ok this way even if it's a long text.

User avatar
Jacob
Registered User
Posts: 100
Joined: Wed Jan 04, 2012 1:41 pm

Re: [RFC]New Forum permission

Post by Jacob » Wed Feb 01, 2012 12:01 pm

I like the idea. And I'd like it to be in the core, but if not at least as a mod.

If a few permissions are removed I don't think it would be bad to add a new one.

User avatar
brunoais
Registered User
Posts: 958
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC]New Forum permission

Post by brunoais » Mon Feb 06, 2012 1:00 pm

Due to the spirit of the permissions system, I think the name should not be something that limits but something that allows.
In other words, when the option is set to yes, it should allow the user to see, do, etc... more than if set to no.
More comments?

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC]New Forum permission

Post by imkingdavid » Mon Feb 06, 2012 2:18 pm

brunoais wrote:Due to the spirit of the permissions system, I think the name should not be something that limits but something that allows.
In other words, when the option is set to yes, it should allow the user to see, do, etc... more than if set to no.
More comments?
Unfortunately, the point of this permission is to limit what topics the user can see. So it may be hard to figure out a way to say it in a way that doesn't sound like it's limiting. Also, because it's the admin that sees the permissions, rather than the user, I don't think it would be an issue if the text is "limiting"

Here's what I'd go with: "Can only view own topics".
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

Post Reply