[RFC] Revamp of styles section of acp

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty »

After a bit more thinking, it might be a good idea to allow installing styles without installing parent style.

Then the following things will have to be changed:
  • Styles list in acp_styles will show all available styles as tree. Styles that are present in phpbb_styles table will be shown as installed, other styles will be shown as not installed.
  • Style preview will use style path instead of id, allowing admins to preview styles before installing it.
  • style_active field in phpbb_styles will be removed.
  • "Install styles" section will be removed.
  • Users will be able to select any installed style, unless override_user_style is enabled.
  • It will require new class for styles tree, allowing forum to locate all parent styles when user previews style from path. Something like phpbb_styles_list
and completely new acp_styles, which I'll gladly write.
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: [RFC] Revamp of styles section of acp

Post by naderman »

Well that sounds to me like we should just display templates require because of inheritance as such, rather than just "uninstalled". But it really doesn't sound like there is any point in distinguishing between deactivated and uninstalled styles. Afterall files could be deleted either way, the only difference is how it is displayed in the ACP:
User avatar
naderman
Consultant
Posts: 1727
Joined: Sun Jan 11, 2004 2:11 am
Location: Berlin, Germany
Contact:

Re: [RFC] Revamp of styles section of acp

Post by naderman »

Oh oops, damn quick reply. Didn't realise I wasn't on the last page, my previous post was written without knowledge of your last post. That sounds better indeed.

There should be a phpbb_styles_manager taking care of the logic. So that acp_styles is really just the user interface.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty »

I've put this idea in separate RFC: viewtopic.php?f=108&t=42921
Post Reply