[RFC] Revamp of styles section of acp

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Revamp of styles section of acp

Post by imkingdavid »

Arty wrote:How about this? installed styles list, uninstalled styles
Looks good to me.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Revamp of styles section of acp

Post by brunoais »

Arty wrote:How about this? installed styles list, uninstalled styles
* brunoais likes it
User avatar
Oyabun1
Former Team Member
Posts: 20
Joined: Thu Mar 31, 2011 9:48 am

Re: [RFC] Revamp of styles section of acp

Post by Oyabun1 »

Arty wrote:How about this? installed styles list, uninstalled styles
+1
User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC] Revamp of styles section of acp

Post by nextgen »

Arty wrote:How about this? installed styles list, uninstalled styles
I like this changed
*Imagine a signature super spectacular.*
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 1864
Joined: Thu Mar 02, 2006 4:29 pm
Location: Earth
Contact:

Re: [RFC] Revamp of styles section of acp

Post by DavidIQ »

I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
Image
User avatar
nextgen
Registered User
Posts: 128
Joined: Sat Jul 24, 2010 4:59 am
Location: Guatemala
Contact:

Re: [RFC] Revamp of styles section of acp

Post by nextgen »

DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
A similar option is selected as the forums through a drop-down menu.
example.jpg
(57.16 KiB) Downloaded 1522 times
*Imagine a signature super spectacular.*
User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Revamp of styles section of acp

Post by brunoais »

DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
It's supposed to work in such way that child themes do not overlap completely their parent themes. So, if you don't want a user to be able to see a parent theme and not the child theme, then you'll have only a partial theme where things are going to be missing.
If you have a complete new theme, don't make it child of another theme, just point that it was made based on that theme.
Hum... nextgen has the 2nd part of my answer
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty »

DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
It will work fine. Deactivating style only hides it from user selection, it doesn't do anything else, so template inheritance works fine regardless of style status and users can select child styles if parent has been deactivated.
User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Revamp of styles section of acp

Post by imkingdavid »

DavidIQ wrote:I like the layout, however I don't know about the requirement of the parent style having to be active. What if I only want the child style to be available for users to select but not the parent?
Just in case you're confusing terminology, installed != active. Yes there are requirements for parent styles to be installed before child styles are, but the parent style does not have to be active for child styles to be.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.
User avatar
Arty
Former Team Member
Posts: 985
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty »

I've tried to redo all commits, messed up pull request while doing it, so I've closed old PR and made new one instead: https://github.com/phpbb/phpbb3/pull/577
Post Reply