[RFC] Revamp of styles section of acp

Note: We are moving the topics of this forum and it will be deleted at some point

Publish your own request for comments/change or patches for the next version of phpBB. Discuss the contributions and proposals of others. Upcoming releases are 3.2/Rhea and 3.3.
User avatar
Arty
Registered User
Posts: 971
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

[RFC] Revamp of styles section of acp

Post by Arty » Mon Jan 16, 2012 12:24 am

This RFC is addition to [RFC] Merge style components

Introduction

With removal of styles components, theme and template sections of styles section of admin control panel become pointless. Layout will require moving stuff around.

Proposal

I propose to revamp styles section of admin control panel.

Menu on left side:
- Installed Styles (default item)
- Install Style
- Purge Cache

Installed Styles shows list of styles that are installed. It will be separated into two sections: active styles and inactive styles. Each row will have these items:
- Style name
- Used by, which shows number of users using it
- Default style column: radio box, allowing admin to quickly change default style
- Options block.

Options block in installed styles section will include:
- Activate / Deactivate (same as now)
- Details. This will allow admin to rename style and will show copyright, version and template inheritance information
- Edit. This will allow admin to edit css and template files. It will be shown as directory tree browser, allowing admin to select .html and .css files within style directory and edit them.
- Delete (same as now)
- Preview (same as now)

Install Style section will show list of available styles, similar to end of styles section now. In addition, if php has write permission to styles directory, it will have option to upload and install style.

Purge Cache section: copy of "purge cache" button from admin control panel index. It is confusing for users to having to go to acp index to clear compiled templates cache, so this menu item will help.

Patch
Ticket: click here
Pull request: click here
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
hanakin
Infrastructure Team
Infrastructure Team
Posts: 841
Joined: Sat Dec 25, 2010 9:02 pm
Contact:

Re: [RFC] Revamp of styles section of acp

Post by hanakin » Sat Jan 21, 2012 2:03 am

+1 as long as you keep in the general section as well as its more convenient for me that way. also possibly consider adding setting to constantly refresh the stale theme here as well as under load settings because that more than anything is the most confusing thing for most users

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Revamp of styles section of acp

Post by MichaelC » Thu Feb 02, 2012 5:12 pm

For reference I found a MOD which uploads and deletes styles http://www.phpbb.com/community/viewtopi ... &t=2143122
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
Arty
Registered User
Posts: 971
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty » Tue Feb 14, 2012 3:08 pm

I'm working on this right now and looking for feedback: which styles display method is better?

1. Alternate row colors by style level: uninstalled styles and installed styles
2. Alternate row colors for each row: uninstalled styles and installed styles
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
MichaelC
Development Team
Development Team
Posts: 889
Joined: Thu Jan 28, 2010 6:29 pm

Re: [RFC] Revamp of styles section of acp

Post by MichaelC » Tue Feb 14, 2012 3:15 pm

Arty wrote:I'm working on this right now and looking for feedback: which styles display method is better?

1. Alternate row colors by style level: uninstalled styles and installed styles
2. Alternate row colors for each row: uninstalled styles and installed styles
Personally I think by style level looks better.

On a general note though, it looks nice. :)
Formerly known as Unknown Bliss
psoTFX wrote: I went with Olympus because as I said to the teams ... "It's been one hell of a hill to climb"
No unsolicited PMs please except for quotes.

User avatar
brunoais
Registered User
Posts: 964
Joined: Fri Dec 18, 2009 3:55 pm

Re: [RFC] Revamp of styles section of acp

Post by brunoais » Tue Feb 14, 2012 3:29 pm

I think a 2 level speparating syling would be better.
The objective is to have separate style for the inner ones vs the outer ones.
For that we'd need 4 colors, though.
Having in account that imagem it would have the colors:
color1
color2
color3
color4
color1
color3
color4
color1

OR

color1
color2
color3
color4
color1
color3
color4
color2

What do you think?

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Revamp of styles section of acp

Post by imkingdavid » Tue Feb 14, 2012 3:42 pm

Arty wrote:I'm working on this right now and looking for feedback: which styles display method is better?

1. Alternate row colors by style level: uninstalled styles and installed styles
2. Alternate row colors for each row: uninstalled styles and installed styles
#1 looks nicer.

Though there aren't very many styles to which this next bit applies, how does this handle styles that aren't based on prosilver or subsilver (i.e. complete rewrites). There's at least one in the styles in development forum, iirc that does that.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Arty
Registered User
Posts: 971
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty » Tue Feb 14, 2012 3:55 pm

brunoais wrote:I think a 2 level speparating syling would be better.
The objective is to have separate style for the inner ones vs the outer ones.
For that we'd need 4 colors, though.
I like that idea!
imkingdavid wrote:how does this handle styles that aren't based on prosilver or subsilver (i.e. complete rewrites).
Styles are shown as tree based on template inheritance. prosilver and subsilver2 don't have parent styles, so they are shown on root level. Same applies to all other styles that don't have parent styles.

Even though template system supports only 1 level deep trees, code in styles management doesn't have that limitation, allowing to implement infinite level deep style trees.
Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

User avatar
imkingdavid
Registered User
Posts: 1050
Joined: Thu Jul 30, 2009 12:06 pm

Re: [RFC] Revamp of styles section of acp

Post by imkingdavid » Tue Feb 14, 2012 3:59 pm

Arty wrote:
imkingdavid wrote:how does this handle styles that aren't based on prosilver or subsilver (i.e. complete rewrites).
Styles are shown as tree based on template inheritance. prosilver and subsilver2 don't have parent styles, so they are shown on root level. Same applies to all other styles that don't have parent styles.

Even though template system supports only 1 level deep trees, code in styles management doesn't have that limitation, allowing to implement infinite level deep style trees.
Ahh, right, that makes sense. Alright.
I do custom MODs. PM for a quote!
View My: MODs | Portfolio
Please do NOT contact for support via PM or email.
Remember, the enemy's gate is down.

User avatar
Arty
Registered User
Posts: 971
Joined: Wed Mar 06, 2002 2:36 pm
Location: Mars
Contact:

Re: [RFC] Revamp of styles section of acp

Post by Arty » Wed Feb 15, 2012 1:57 pm

Formerly known as CyberAlien.

Free phpBB styles | Premium responsive XenForo styles

Post Reply